Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWAA verify TOP_LEVEL_DOMAIN is None #220

Open
nagulvali555 opened this issue Jul 13, 2023 · 2 comments
Open

MWAA verify TOP_LEVEL_DOMAIN is None #220

nagulvali555 opened this issue Jul 13, 2023 · 2 comments

Comments

@nagulvali555
Copy link

MWAA verify script fails with below error

top_level_domain = TOP_LEVEL_DOMAIN.split(".").reverse().join(".")

AttributeError: 'NoneType' object has no attribute 'join'

the above join statement seems to be wrong

@leneffets
Copy link

Same here:

### Trying to verify if route tables are valid...
Route Table: rtb-123456789 does not have a route to a NAT Gateway
checking for VPC endpoints to airflow, s3, sqs, kms, ecr, and monitoring
Traceback (most recent call last):
  File "/home/t1-712980/git/aws-support-tools/MWAA/verify_env/verify_env.py", line 989, in <module>
    check_routes(env, subnets, subnet_ids, ec2)
  File "/home/t1-712980/git/aws-support-tools/MWAA/verify_env/verify_env.py", line 742, in check_routes
    check_service_vpc_endpoints(ec2_client, input_subnets)
  File "/home/t1-712980/git/aws-support-tools/MWAA/verify_env/verify_env.py", line 658, in check_service_vpc_endpoints
    top_level_domain = TOP_LEVEL_DOMAIN.split(".").reverse().join(".")
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'join'

@yingchenjun
Copy link

Got the same error here. do we know the cause here?

### Trying to verify if route tables are valid...
Route Table: rtb-xxxxxxxxxx does not have a route to a NAT Gateway
checking for VPC endpoints to airflow, s3, sqs, kms, ecr, and monitoring
Traceback (most recent call last):
  File "aws-support-tools/MWAA/verify_env/verify_env.py", line 989, in <module>
    check_routes(env, subnets, subnet_ids, ec2)
  File "aws-support-tools/MWAA/verify_env/verify_env.py", line 742, in check_routes
    check_service_vpc_endpoints(ec2_client, input_subnets)
  File "aws-support-tools/MWAA/verify_env/verify_env.py", line 658, in check_service_vpc_endpoints
    top_level_domain = TOP_LEVEL_DOMAIN.split(".").reverse().join(".")
AttributeError: 'NoneType' object has no attribute 'join'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants