Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable load boundary cutoff only when backtrack cost favoring executes!! #195

Open
leijurv opened this issue Oct 2, 2018 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@leijurv
Copy link
Member

leijurv commented Oct 2, 2018

This gets you the best of both worlds, with regards to path safety and optimality (i.e. having load boundary cutoff on for most of the time), but still preventing oscillation (between the best loaded point, and the cache-edge of the workaround path) if a backtrack beyond the load boundary is required (which happens ALL THE TIME in 2b2t spawn lol), because a backtrack DISABLES load boundary cutoff! And yet we still have all the safeguards (cost verification lookahead, maximum cost increase limits, etc) to make that one-time cached path safe. I think cutoffAtLoadBoundary should default to false, but if you turn it on, there should be a second option, defaulting to true, that overrides that cutoff to false if the best path involved any backtracking.

@leijurv leijurv added the enhancement New feature or request label Oct 2, 2018
@leijurv leijurv self-assigned this Oct 2, 2018
@leijurv
Copy link
Member Author

leijurv commented Nov 9, 2018

This is still a good idea, but cutoffAtLoadBoundary defaults to false now, so it won't really have any effect on anyone...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant