Skip to content

Commit 0579d7e

Browse files
cnuernbercnuernber
committed
Cleaned up linting issues.
1 parent c5f422f commit 0579d7e

File tree

8 files changed

+84
-122
lines changed

8 files changed

+84
-122
lines changed

‎.clj-kondo/config.edn

+4-1
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,5 @@
11
{:config-paths ["cnuernber/dtype-next"]
2-
:skip-comments false}
2+
:skip-comments true
3+
;;We have to use private calls into the cljs runtime in order to avoid duplicating
4+
;;some pretty dirty code.
5+
:linters {:private-call {:level :off}}}

‎src/tech/v3/datatype/arrays.cljs

+36-33
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,7 @@
196196
(equiv-agetable this other))
197197
ICloneable
198198
(-clone [item]
199+
#_:clj-kondo/ignore
199200
(let [len (aget item "length")
200201
retval (js* "new item.constructor(len)")]
201202
(.set retval item)
@@ -216,8 +217,10 @@
216217
(-count [array] (.-length array))
217218
IReduce
218219
(-reduce
219-
([array f] (array-reduce array f))
220-
([array f start] (array-reduce array f start)))
220+
([array f]
221+
(array-reduce array f))
222+
([array f start]
223+
(array-reduce array f start)))
221224
IPrintWithWriter
222225
(-pr-writer [rdr writer opts]
223226
(-write writer (dt-base/reader->str rdr "typed-array")))
@@ -329,16 +332,16 @@
329332
;;Booleans are stored as 1,0 bytes.
330333
(deftype BooleanArray [buf metadata ^:unsynchronized-mutable hashcode]
331334
ICounted
332-
(-count [item] (count buf))
335+
(-count [_item] (count buf))
333336
ICloneable
334-
(-clone [item] (make-boolean-array (clone buf) metadata))
337+
(-clone [_item] (make-boolean-array (clone buf) metadata))
335338
dt-proto/PElemwiseDatatype
336-
(-elemwise-datatype [item] :boolean)
339+
(-elemwise-datatype [_item] :boolean)
337340
dt-proto/PSubBufferCopy
338-
(-sub-buffer-copy [item off len]
341+
(-sub-buffer-copy [_item off len]
339342
(make-boolean-array (dt-proto/-sub-buffer-copy buf off len) metadata))
340343
dt-proto/PSubBuffer
341-
(-sub-buffer [item off len]
344+
(-sub-buffer [_item off len]
342345
(make-boolean-array (dt-proto/-sub-buffer buf off len) metadata))
343346
dt-proto/PSetValue
344347
(-set-value! [item idx data]
@@ -360,29 +363,29 @@
360363
IIterable
361364
(-iterator [this] (nth-iter this))
362365
dt-proto/PToTypedArray
363-
(-convertible-to-typed-array? [this] true)
364-
(->typed-array [this] buf)
366+
(-convertible-to-typed-array? [_this] true)
367+
(->typed-array [_this] buf)
365368
;;Disable aget for this buffer. This is because it will result in algorithms
366369
;;getting the base buffer which will mean they get 1,0 instead of true,false.
367370
dt-proto/PAgetable
368-
(-convertible-to-agetable? [this] false)
371+
(-convertible-to-agetable? [_this] false)
369372
IWithMeta
370373
(-with-meta [coll new-meta]
371374
(if (identical? new-meta metadata)
372375
coll
373376
(BooleanArray. buf new-meta nil)))
374377
IMeta
375-
(-meta [coll] metadata)
378+
(-meta [_coll] metadata)
376379
IPrintWithWriter
377-
(-pr-writer [rdr writer opts]
380+
(-pr-writer [rdr writer _opts]
378381
(-write writer (dt-base/reader->str rdr "typed-array")))
379382
ISequential
380383
ISeqable
381-
(-seq [array]
384+
(-seq [_array]
382385
(when-not (zero? (count buf))
383386
(map byte->boolean buf)))
384387
ISeq
385-
(-first [array] (byte->boolean (nth buf 0)))
388+
(-first [_array] (byte->boolean (nth buf 0)))
386389
(-rest [array] (dt-base/sub-buffer array 1 (dec (count buf))))
387390
IFn
388391
(-invoke [array n]
@@ -405,22 +408,22 @@
405408
;;Necessary to add an actual datatype to a js array and metadata to typed arrays
406409
(deftype TypedBuffer [buf elem-dtype metadata ^:unsynchronized-mutable hashcode]
407410
ICounted
408-
(-count [item] (count buf))
411+
(-count [_item] (count buf))
409412
ICloneable
410-
(-clone [item] (make-typed-buffer (clone buf) elem-dtype metadata))
413+
(-clone [_item] (make-typed-buffer (clone buf) elem-dtype metadata))
411414
dt-proto/PElemwiseDatatype
412-
(-elemwise-datatype [item] elem-dtype)
415+
(-elemwise-datatype [_item] elem-dtype)
413416
dt-proto/PToJSArray
414-
(-convertible-to-js-array? [item] (dt-proto/-convertible-to-js-array? buf))
415-
(->js-array [item] (dt-proto/->js-array buf))
417+
(-convertible-to-js-array? [_item] (dt-proto/-convertible-to-js-array? buf))
418+
(->js-array [_item] (dt-proto/->js-array buf))
416419
dt-proto/PToTypedArray
417-
(-convertible-to-typed-array? [item] (dt-proto/-convertible-to-typed-array? buf))
418-
(->typed-array [item] (dt-proto/->typed-array buf))
420+
(-convertible-to-typed-array? [_item] (dt-proto/-convertible-to-typed-array? buf))
421+
(->typed-array [_item] (dt-proto/->typed-array buf))
419422
dt-proto/PSubBufferCopy
420-
(-sub-buffer-copy [item off len]
423+
(-sub-buffer-copy [_item off len]
421424
(make-typed-buffer (dt-base/sub-buffer-copy buf off len) elem-dtype metadata))
422425
dt-proto/PSubBuffer
423-
(-sub-buffer [item off len]
426+
(-sub-buffer [_item off len]
424427
(make-typed-buffer (dt-base/sub-buffer buf off len) elem-dtype metadata))
425428
dt-proto/PSetValue
426429
(-set-value! [item idx data]
@@ -431,23 +434,23 @@
431434
(dt-proto/-set-constant! buf offset elem-count data)
432435
item)
433436
IReduce
434-
(-reduce [array f] (-reduce buf f))
435-
(-reduce [array f start] (-reduce buf f start))
437+
(-reduce [_array f] (-reduce buf f))
438+
(-reduce [_array f start] (-reduce buf f start))
436439
IWithMeta
437440
(-with-meta [coll new-meta]
438441
(if (identical? new-meta metadata)
439442
coll
440443
(make-typed-buffer buf elem-dtype new-meta)))
441444
IMeta
442-
(-meta [coll] metadata)
445+
(-meta [_coll] metadata)
443446
IPrintWithWriter
444-
(-pr-writer [rdr writer opts]
447+
(-pr-writer [rdr writer _opts]
445448
(-write writer (dt-base/reader->str rdr "typed-buffer")))
446449
ISeqable
447-
(-seq [array] (array-seq buf))
450+
(-seq [_array] (array-seq buf))
448451
ISeq
449-
(-first [array] (nth buf 0))
450-
(-rest [array] (dt-proto/-sub-buffer buf 1 (dec (count buf))))
452+
(-first [_array] (nth buf 0))
453+
(-rest [_array] (dt-proto/-sub-buffer buf 1 (dec (count buf))))
451454
IFn
452455
(-invoke [array n]
453456
(nth-impl n (count array) nil nth buf))
@@ -458,20 +461,20 @@
458461
(nth-impl n (count array) not-found nth buf))
459462
ISequential
460463
IHash
461-
(-hash [o]
464+
(-hash [_o]
462465
(when-not hashcode
463466
(set! hashcode
464467
(if-let [aget-buf (dt-base/as-agetable buf)]
465468
(hash-agetable aget-buf)
466469
(hash-nthable buf))))
467470
hashcode)
468471
IEquiv
469-
(-equiv [this other]
472+
(-equiv [_this other]
470473
(if-let [aget-buf (dt-base/as-agetable buf)]
471474
(equiv-agetable aget-buf other)
472475
(equiv-nthable buf other)))
473476
IIterable
474-
(-iterator [this] (index-iter buf)))
477+
(-iterator [_this] (index-iter buf)))
475478

476479

477480
(defn make-typed-buffer

‎src/tech/v3/datatype/base.cljs

+1-1
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@
204204
(dotimes [idx n-elems]
205205
(consume-fn idx (nth item idx))))
206206
:else
207-
(if-let [item (seq item)]
207+
(when-let [item (seq item)]
208208
(loop [val (first item)
209209
item (rest item)
210210
idx 0]

‎src/tech/v3/datatype/bitmap.cljs

-41
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
"set implementation specialized towards unsigned 32 bit integers."
33
(:require [tech.v3.datatype.protocols :as dt-proto]
44
[tech.v3.datatype.base :as dt-base]
5-
[tech.v3.datatype.copy-make-container :as dt-cmc]
65
[tech.v3.datatype.list :as dt-list]
76
[clojure.set :as set]))
87

@@ -124,43 +123,3 @@
124123
(if (.-done next-val)
125124
(persistent! retval)
126125
(recur (conj! retval (.-value next-val))))))))
127-
128-
129-
(comment
130-
;;construction
131-
(def ignored
132-
(do
133-
(println "set construction")
134-
(def data (time (->bitmap (range 1000000))))
135-
(println "set union")
136-
(time (dt-proto/-set-or data data))
137-
(println "to ordered indexes")
138-
(time (set->ordered-indexes data))))
139-
140-
141-
;; set construction
142-
;; "Elapsed time: 119.516597 msecs"
143-
;; set union
144-
;; "Elapsed time: 363.884627 msecs"
145-
;; to ordered indexes
146-
;; "Elapsed time: 26.387132 msecs"
147-
148-
149-
(def ignored
150-
(do
151-
(println "set construction")
152-
(def data (time (set (range 1000000))))
153-
(println "set-union")
154-
(time (set/union data data))
155-
(println "to ordered indexes")
156-
(time (set->ordered-indexes data))))
157-
158-
159-
;; set construction
160-
;; "Elapsed time: 1146.016398 msecs"
161-
;; set-union
162-
;; "Elapsed time: 877.601483 msecs"
163-
;; to ordered indexes
164-
;; "Elapsed time: 389.167092 msecs"
165-
166-
)

‎src/tech/v3/datatype/list.cljs

+22-22
Original file line numberDiff line numberDiff line change
@@ -18,26 +18,26 @@
1818
^:unsynchronized-mutable hashcode
1919
metadata]
2020
ICounted
21-
(-count [this] ptr)
21+
(-count [_this] ptr)
2222
ICloneable
23-
(-clone [this] (make-primitive-list
24-
(-> (dt-proto/-sub-buffer buf 0 ptr)
25-
(clone))
26-
dtype ptr))
23+
(-clone [_this] (make-primitive-list
24+
(-> (dt-proto/-sub-buffer buf 0 ptr)
25+
(clone))
26+
dtype ptr))
2727
IMeta
28-
(-meta [this] metadata)
28+
(-meta [_this] metadata)
2929
IWithMeta
30-
(-with-meta [this new-meta]
30+
(-with-meta [_this new-meta]
3131
(make-primitive-list buf dtype ptr new-meta))
3232
IPrintWithWriter
33-
(-pr-writer [rdr writer opts]
33+
(-pr-writer [rdr writer _opts]
3434
(-write writer (dt-base/reader->str rdr "list")))
3535
ISequential
3636
ISeqable
37-
(-seq [array] (array-seq (dt-proto/-sub-buffer buf 0 ptr)))
37+
(-seq [_array] (array-seq (dt-proto/-sub-buffer buf 0 ptr)))
3838
ISeq
39-
(-first [array] (nth buf 0))
40-
(-rest [array] (dt-proto/-sub-buffer buf 1 (dec (count buf))))
39+
(-first [_array] (nth buf 0))
40+
(-rest [_array] (dt-proto/-sub-buffer buf 1 (dec (count buf))))
4141
IFn
4242
(-invoke [array n]
4343
(let [n (if (< n 0) (+ (count array) n) n)]
@@ -63,29 +63,29 @@
6363
(-iterator [this] (dt-arrays/nth-iter this))
6464

6565
dt-proto/PElemwiseDatatype
66-
(-elemwise-datatype [this] dtype)
66+
(-elemwise-datatype [_this] dtype)
6767
dt-proto/PDatatype
68-
(-datatype [this] :list)
68+
(-datatype [_this] :list)
6969
dt-proto/PSubBufferCopy
70-
(-sub-buffer-copy [item offset length]
70+
(-sub-buffer-copy [_item offset length]
7171
(dt-arrays/make-typed-buffer (dt-proto/-sub-buffer-copy buf offset length)
7272
dtype metadata))
7373
dt-proto/PSubBuffer
74-
(-sub-buffer [item offset length]
74+
(-sub-buffer [_item offset length]
7575
(dt-arrays/make-typed-buffer (dt-proto/-sub-buffer buf offset length)
7676
dtype metadata))
7777
dt-proto/PToTypedArray
78-
(-convertible-to-typed-array? [this] (dt-proto/-convertible-to-typed-array? buf))
79-
(->typed-array [this] (dt-proto/->typed-array (dt-proto/-sub-buffer buf 0 ptr)))
78+
(-convertible-to-typed-array? [_this] (dt-proto/-convertible-to-typed-array? buf))
79+
(->typed-array [_this] (dt-proto/->typed-array (dt-proto/-sub-buffer buf 0 ptr)))
8080

8181
dt-proto/PToJSArray
82-
(-convertible-to-js-array? [this] (dt-proto/-convertible-to-js-array? buf))
83-
(->js-array [this] (dt-proto/->js-array (dt-proto/-sub-buffer buf 0 ptr)))
82+
(-convertible-to-js-array? [_this] (dt-proto/-convertible-to-js-array? buf))
83+
(->js-array [_this] (dt-proto/->js-array (dt-proto/-sub-buffer buf 0 ptr)))
8484

8585

8686
dt-proto/PAgetable
87-
(-convertible-to-agetable? [this] (dt-proto/-convertible-to-agetable? buf))
88-
(->agetable [this] (dt-proto/->agetable (dt-proto/-sub-buffer buf 0 ptr)))
87+
(-convertible-to-agetable? [_this] (dt-proto/-convertible-to-agetable? buf))
88+
(->agetable [_this] (dt-proto/->agetable (dt-proto/-sub-buffer buf 0 ptr)))
8989

9090
dt-proto/PSetValue
9191
(-set-value! [item idx data]
@@ -94,7 +94,7 @@
9494
(dt-base/set-value! idx data))
9595
item)
9696
dt-proto/PSetConstant
97-
(-set-constant! [item offset elem-count data]
97+
(-set-constant! [_item offset elem-count data]
9898
(-> (dt-proto/-sub-buffer buf 0 ptr)
9999
(dt-base/set-constant! offset elem-count data)))
100100
dt-proto/PListLike

0 commit comments

Comments
 (0)