-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 53 #2 #83
Open
Tarhab
wants to merge
383
commits into
codeforamerica:master
Choose a base branch
from
sfbrigade:production
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Issue 53 #2 #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove button to remind users from modal
Add link to learn more about adopting a drain to unauthenticated adopt modal
Were ’ instead of 's due to copy/paste error
Add system use code to things
Update social media sharing copy
More visually consistent
Update favicon to be similar to map marker
To bring it inline with current revisions.
Not sure why these were hidden, but it seems like a good idea to always have the visible. Fixes #117
Bring it up to date -- missed db:migrate
Currently just hardcoding the one special case that we have, but we should generalize if we add more.
Add icons for drains to bay or ocean
Update e-mail copy for first e-mail
Current domains are invalid, update to real ones
Update screenshot in README
Make route work for README image
as this is redundant Fixes #127
Update default mail host and devise email mailer
Strip `Available -` from legend
Update feedback e-mail to [email protected]
Addresses #44
Same as alt text minus the word 'icon' as it'd be redundant.
Add alt text to icons in legend
Bumps [uglifier](https://github.com/lautis/uglifier) from 4.1.5 to 4.1.6. - [Changelog](https://github.com/lautis/uglifier/blob/master/CHANGELOG.md) - [Commits](lautis/uglifier@v4.1.5...v4.1.6)
Bumps [skylight](https://github.com/skylightio/skylight-ruby) from 1.5.0 to 1.5.1. - [Changelog](https://github.com/skylightio/skylight-ruby/blob/master/CHANGELOG.md) - [Commits](skylightio/skylight-ruby@v1.5.0...v1.5.1)
Bumps [rails_admin](https://github.com/sferik/rails_admin) from 1.2.0 to 1.3.0. - [Changelog](https://github.com/sferik/rails_admin/blob/master/CHANGELOG.md) - [Commits](railsadminteam/rails_admin@v1.2.0...v1.3.0)
Bumps [skylight](https://github.com/skylightio/skylight-ruby) from 1.5.1 to 1.6.0. - [Release notes](https://github.com/skylightio/skylight-ruby/releases) - [Changelog](https://github.com/skylightio/skylight-ruby/blob/master/CHANGELOG.md) - [Commits](skylightio/skylight-ruby@v1.5.1...v1.6.0) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [puma](https://github.com/puma/puma) from 3.11.2 to 3.11.3. - [Release notes](https://github.com/puma/puma/releases) - [Changelog](https://github.com/puma/puma/blob/master/History.md) - [Commits](puma/puma@v3.11.2...v3.11.3) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [byebug](https://github.com/deivid-rodriguez/byebug) from 10.0.0 to 10.0.2. - [Release notes](https://github.com/deivid-rodriguez/byebug/releases) - [Changelog](https://github.com/deivid-rodriguez/byebug/blob/master/CHANGELOG.md) - [Commits](deivid-rodriguez/byebug@v10.0.0...v10.0.2) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [uglifier](https://github.com/lautis/uglifier) from 4.1.6 to 4.1.8. - [Release notes](https://github.com/lautis/uglifier/releases) - [Changelog](https://github.com/lautis/uglifier/blob/master/CHANGELOG.md) - [Commits](lautis/uglifier@v4.1.6...v4.1.8) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [rubocop](https://github.com/bbatsov/rubocop) from 0.52.1 to 0.54.0. - [Release notes](https://github.com/bbatsov/rubocop/releases) - [Changelog](https://github.com/bbatsov/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v0.52.1...v0.54.0) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [devise](https://github.com/plataformatec/devise) from 3.5.10 to 4.3.0. - [Changelog](https://github.com/plataformatec/devise/blob/master/CHANGELOG.md) - [Commits](heartcombo/devise@v3.5.10...v4.3.0)
Only one input. The most common error should be that the e-mail wasn't found.
Was not parsing correctly
Will automatically use the one in .ruby-version
Until CI bug is fixed travis-ci/travis-ci#8978 (comment) Didn't realize 2.5.1 was hot of the presses
To be compatible with Ruby 2.5.0
To match the labeling on the user registration form as this is the labeling people are most likely to have seen. Update the user profile edit form to match this as labeling.
Bumps [dotenv-rails](https://github.com/bkeepers/dotenv) from 2.2.1 to 2.4.0. - [Release notes](https://github.com/bkeepers/dotenv/releases) - [Changelog](https://github.com/bkeepers/dotenv/blob/master/Changelog.md) - [Commits](bkeepers/dotenv@v2.2.1...v2.4.0) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [webmock](https://github.com/bblimke/webmock) from 3.3.0 to 3.4.0. - [Release notes](https://github.com/bblimke/webmock/releases) - [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md) - [Commits](bblimke/webmock@v3.3.0...v3.4.0) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [paranoia](https://github.com/rubysherpas/paranoia) from 2.4.0 to 2.4.1. - [Release notes](https://github.com/rubysherpas/paranoia/releases) - [Changelog](https://github.com/rubysherpas/paranoia/blob/core/CHANGELOG.md) - [Commits](rubysherpas/paranoia@v2.4.0...v2.4.1) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [uglifier](https://github.com/lautis/uglifier) from 4.1.8 to 4.1.10. - [Release notes](https://github.com/lautis/uglifier/releases) - [Changelog](https://github.com/lautis/uglifier/blob/master/CHANGELOG.md) - [Commits](lautis/uglifier@v4.1.8...v4.1.10) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [skylight](https://github.com/skylightio/skylight-ruby) from 1.6.0 to 2.0.0. - [Release notes](https://github.com/skylightio/skylight-ruby/releases) - [Changelog](https://github.com/skylightio/skylight-ruby/blob/master/CHANGELOG.md) - [Commits](skylightio/skylight-ruby@v1.6.0...v2.0.0) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [airbrake](https://github.com/airbrake/airbrake) from 7.2.1 to 7.3.0. - [Release notes](https://github.com/airbrake/airbrake/releases) - [Changelog](https://github.com/airbrake/airbrake/blob/master/docs/CHANGELOG-pre-v5.txt) - [Commits](airbrake/airbrake@v7.2.1...v7.3.0) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [puma](https://github.com/puma/puma) from 3.11.3 to 3.11.4. - [Release notes](https://github.com/puma/puma/releases) - [Changelog](https://github.com/puma/puma/blob/master/History.md) - [Commits](puma/puma@v3.11.3...v3.11.4) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [rubocop](https://github.com/bbatsov/rubocop) from 0.54.0 to 0.55.0. - [Release notes](https://github.com/bbatsov/rubocop/releases) - [Changelog](https://github.com/bbatsov/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v0.54.0...v0.55.0) Signed-off-by: dependabot[bot] <[email protected]>
Useful for generating report for deleted adopted drains
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the correct CSS file so that the fonts work properly on the registration page.