[release 1.2] fix: linter issue

fuweid · crosbymichael · commit bf3c932a5b5e · 2019-01-23T11:35:21.000-05:00
megacheck, gosimple and unused has been deprecated and subsumed by staticcheck. And staticcheck also has been upgraded. we need to update code for the linter issue. close: #2945 Signed-off-by: Wei Fu <fuweid89@gmail.com> Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
diff --git a/.gometalinter.json b/.gometalinter.json
@@ -10,7 +10,6 @@
 
   "Enable": [
     "structcheck",
-    "unused",
     "varcheck",
     "staticcheck",
     "unconvert",
diff --git a/archive/tar.go b/archive/tar.go
@@ -295,7 +295,7 @@ func applyNaive(ctx context.Context, root string, tr *tar.Reader, options ApplyO
 			linkBasename := filepath.Base(hdr.Linkname)
 			srcHdr = aufsHardlinks[linkBasename]
 			if srcHdr == nil {
-				return 0, fmt.Errorf("Invalid aufs hardlink")
+				return 0, fmt.Errorf("invalid aufs hardlink")
 			}
 			p, err := fs.RootPath(aufsTempdir, linkBasename)
 			if err != nil {
diff --git a/archive/tar_test.go b/archive/tar_test.go
@@ -283,7 +283,7 @@ func TestBreakouts(t *testing.T) {
 			if err != nil {
 				return err
 			}
-			if bytes.Compare(b, content) != 0 {
+			if !bytes.Equal(b, content) {
 				return errors.Errorf("content differs: expected %v, got %v", content, b)
 			}
 			return nil
@@ -1133,7 +1133,7 @@ func fileEntry(name string, expected []byte, mode int) tarEntryValidator {
 		if hdr.Mode != int64(mode) {
 			return errors.Errorf("wrong mode %o, expected %o", hdr.Mode, mode)
 		}
-		if bytes.Compare(b, expected) != 0 {
+		if !bytes.Equal(b, expected) {
 			return errors.Errorf("different file content")
 		}
 		return nil
diff --git a/archive/tar_windows.go b/archive/tar_windows.go
@@ -74,7 +74,7 @@ func tarName(p string) (string, error) {
 	// in file names, it is mostly safe to replace however we must
 	// check just in case
 	if strings.Contains(p, "/") {
-		return "", fmt.Errorf("Windows path contains forward slash: %s", p)
+		return "", fmt.Errorf("windows path contains forward slash: %s", p)
 	}
 
 	return strings.Replace(p, string(os.PathSeparator), "/", -1), nil
@@ -130,11 +130,7 @@ func skipFile(hdr *tar.Header) bool {
 	// specific or Linux-specific, this warning should be changed to an error
 	// to cater for the situation where someone does manage to upload a Linux
 	// image but have it tagged as Windows inadvertently.
-	if strings.Contains(hdr.Name, ":") {
-		return true
-	}
-
-	return false
+	return strings.Contains(hdr.Name, ":")
 }
 
 // handleTarTypeBlockCharFifo is an OS-specific helper function used by
diff --git a/container_linux_test.go b/container_linux_test.go
@@ -911,7 +911,7 @@ func TestDaemonRestartWithRunningShim(t *testing.T) {
 	}
 
 	pid := task.Pid()
-	if pid <= 0 {
+	if pid < 1 {
 		t.Fatalf("invalid task pid %d", pid)
 	}
 
@@ -1201,7 +1201,7 @@ func testUserNamespaces(t *testing.T, readonlyRootFS bool) {
 		t.Fatal(err)
 	}
 
-	if pid := task.Pid(); pid <= 0 {
+	if pid := task.Pid(); pid < 1 {
 		t.Errorf("invalid task pid %d", pid)
 	}
 	if err := task.Start(ctx); err != nil {
diff --git a/container_test.go b/container_test.go
@@ -136,7 +136,7 @@ func TestContainerStart(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	if pid := task.Pid(); pid <= 0 {
+	if pid := task.Pid(); pid < 1 {
 		t.Errorf("invalid task pid %d", pid)
 	}
 	if err := task.Start(ctx); err != nil {
@@ -435,7 +435,7 @@ func TestContainerPids(t *testing.T) {
 	}
 
 	pid := task.Pid()
-	if pid <= 0 {
+	if pid < 1 {
 		t.Errorf("invalid task pid %d", pid)
 	}
 	processes, err := task.Pids(ctx)
@@ -785,7 +785,7 @@ func TestWaitStoppedTask(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	if pid := task.Pid(); pid <= 0 {
+	if pid := task.Pid(); pid < 1 {
 		t.Errorf("invalid task pid %d", pid)
 	}
 	if err := task.Start(ctx); err != nil {
diff --git a/content/local/locks.go b/content/local/locks.go
@@ -47,7 +47,5 @@ func unlock(ref string) {
 	locksMu.Lock()
 	defer locksMu.Unlock()
 
-	if _, ok := locks[ref]; ok {
-		delete(locks, ref)
-	}
+	delete(locks, ref)
 }
diff --git a/contrib/seccomp/seccomp.go b/contrib/seccomp/seccomp.go
@@ -37,10 +37,10 @@ func WithProfile(profile string) oci.SpecOpts {
 		s.Linux.Seccomp = &specs.LinuxSeccomp{}
 		f, err := ioutil.ReadFile(profile)
 		if err != nil {
-			return fmt.Errorf("Cannot load seccomp profile %q: %v", profile, err)
+			return fmt.Errorf("cannot load seccomp profile %q: %v", profile, err)
 		}
 		if err := json.Unmarshal(f, s.Linux.Seccomp); err != nil {
-			return fmt.Errorf("Decoding seccomp profile failed %q: %v", profile, err)
+			return fmt.Errorf("decoding seccomp profile failed %q: %v", profile, err)
 		}
 		return nil
 	}
diff --git a/diff/apply/apply.go b/diff/apply/apply.go
@@ -58,7 +58,7 @@ func (s *fsApplier) Apply(ctx context.Context, desc ocispec.Descriptor, mounts [
 	defer func() {
 		if err == nil {
 			log.G(ctx).WithFields(logrus.Fields{
-				"d":     time.Now().Sub(t1),
+				"d":     time.Since(t1),
 				"dgst":  desc.Digest,
 				"size":  desc.Size,
 				"media": desc.MediaType,
diff --git a/diff/lcow/lcow.go b/diff/lcow/lcow.go
@@ -99,7 +99,7 @@ func (s windowsLcowDiff) Apply(ctx context.Context, desc ocispec.Descriptor, mou
 	defer func() {
 		if err == nil {
 			log.G(ctx).WithFields(logrus.Fields{
-				"d":     time.Now().Sub(t1),
+				"d":     time.Since(t1),
 				"dgst":  desc.Digest,
 				"size":  desc.Size,
 				"media": desc.MediaType,
diff --git a/diff/windows/windows.go b/diff/windows/windows.go
@@ -92,7 +92,7 @@ func (s windowsDiff) Apply(ctx context.Context, desc ocispec.Descriptor, mounts
 	defer func() {
 		if err == nil {
 			log.G(ctx).WithFields(logrus.Fields{
-				"d":     time.Now().Sub(t1),
+				"d":     time.Since(t1),
 				"dgst":  desc.Digest,
 				"size":  desc.Size,
 				"media": desc.MediaType,
diff --git a/filters/scanner.go b/filters/scanner.go
@@ -185,7 +185,6 @@ func (s *scanner) scanQuoted(quote rune) {
 			ch = s.next()
 		}
 	}
-	return
 }
 
 func (s *scanner) scanEscape(quote rune) rune {
diff --git a/import.go b/import.go
@@ -99,8 +99,7 @@ func (c *Client) Import(ctx context.Context, reader io.Reader, opts ...ImportOpt
 		})
 	}
 
-	var handler images.HandlerFunc
-	handler = func(ctx context.Context, desc ocispec.Descriptor) ([]ocispec.Descriptor, error) {
+	var handler images.HandlerFunc = func(ctx context.Context, desc ocispec.Descriptor) ([]ocispec.Descriptor, error) {
 		// Only save images at top level
 		if desc.Digest != index.Digest {
 			return images.Children(ctx, cs, desc)
diff --git a/metadata/content.go b/metadata/content.go
@@ -762,7 +762,7 @@ func (cs *contentStore) garbageCollect(ctx context.Context) (d time.Duration, er
 	t1 := time.Now()
 	defer func() {
 		if err == nil {
-			d = time.Now().Sub(t1)
+			d = time.Since(t1)
 		}
 		cs.l.Unlock()
 	}()
diff --git a/metadata/db.go b/metadata/db.go
@@ -154,7 +154,7 @@ func (m *DB) Init(ctx context.Context) error {
 				if err := m.migrate(tx); err != nil {
 					return errors.Wrapf(err, "failed to migrate to %s.%d", m.schema, m.version)
 				}
-				log.G(ctx).WithField("d", time.Now().Sub(t0)).Debugf("finished database migration to %s.%d", m.schema, m.version)
+				log.G(ctx).WithField("d", time.Since(t0)).Debugf("finished database migration to %s.%d", m.schema, m.version)
 			}
 		}
 
@@ -306,7 +306,7 @@ func (m *DB) GarbageCollect(ctx context.Context) (gc.Stats, error) {
 				m.cleanupSnapshotter(snapshotterName)
 
 				sl.Lock()
-				stats.SnapshotD[snapshotterName] = time.Now().Sub(st1)
+				stats.SnapshotD[snapshotterName] = time.Since(st1)
 				sl.Unlock()
 
 				wg.Done()
@@ -321,15 +321,15 @@ func (m *DB) GarbageCollect(ctx context.Context) (gc.Stats, error) {
 		go func() {
 			ct1 := time.Now()
 			m.cleanupContent()
-			stats.ContentD = time.Now().Sub(ct1)
+			stats.ContentD = time.Since(ct1)
 			wg.Done()
 		}()
 		m.dirtyCS = false
 	}
 
 	m.dirtyL.Unlock()
 
-	stats.MetaD = time.Now().Sub(t1)
+	stats.MetaD = time.Since(t1)
 	m.wlock.Unlock()
 
 	wg.Wait()
diff --git a/metadata/snapshot.go b/metadata/snapshot.go
@@ -628,7 +628,7 @@ func (s *snapshotter) garbageCollect(ctx context.Context) (d time.Duration, err
 			}
 		}
 		if err == nil {
-			d = time.Now().Sub(t1)
+			d = time.Since(t1)
 		}
 	}()
 
diff --git a/mount/mountinfo_linux.go b/mount/mountinfo_linux.go
@@ -68,15 +68,15 @@ func parseInfoFile(r io.Reader) ([]Info, error) {
 		numFields := len(fields)
 		if numFields < 10 {
 			// should be at least 10 fields
-			return nil, fmt.Errorf("Parsing '%s' failed: not enough fields (%d)", text, numFields)
+			return nil, fmt.Errorf("parsing '%s' failed: not enough fields (%d)", text, numFields)
 		}
 		p := Info{}
 		// ignore any numbers parsing errors, as there should not be any
 		p.ID, _ = strconv.Atoi(fields[0])
 		p.Parent, _ = strconv.Atoi(fields[1])
 		mm := strings.Split(fields[2], ":")
 		if len(mm) != 2 {
-			return nil, fmt.Errorf("Parsing '%s' failed: unexpected minor:major pair %s", text, mm)
+			return nil, fmt.Errorf("parsing '%s' failed: unexpected minor:major pair %s", text, mm)
 		}
 		p.Major, _ = strconv.Atoi(mm[0])
 		p.Minor, _ = strconv.Atoi(mm[1])
@@ -101,11 +101,11 @@ func parseInfoFile(r io.Reader) ([]Info, error) {
 			}
 		}
 		if i == numFields {
-			return nil, fmt.Errorf("Parsing '%s' failed: missing separator ('-')", text)
+			return nil, fmt.Errorf("parsing '%s' failed: missing separator ('-')", text)
 		}
 		// There should be 3 fields after the separator...
 		if i+4 > numFields {
-			return nil, fmt.Errorf("Parsing '%s' failed: not enough fields after a separator", text)
+			return nil, fmt.Errorf("parsing '%s' failed: not enough fields after a separator", text)
 		}
 		// ... but in Linux <= 3.9 mounting a cifs with spaces in a share name
 		// (like "//serv/My Documents") _may_ end up having a space in the last field
diff --git a/pkg/progress/escape.go b/pkg/progress/escape.go
@@ -19,6 +19,6 @@ package progress
 const (
 	escape = "\x1b"
 	reset  = escape + "[0m"
-	red    = escape + "[31m" // nolint: unused, varcheck
+	red    = escape + "[31m" // nolint: staticcheck, varcheck
 	green  = escape + "[32m"
 )
diff --git a/pkg/testutil/helpers_unix.go b/pkg/testutil/helpers_unix.go
@@ -49,7 +49,7 @@ func RequiresRootM() {
 		fmt.Fprintln(os.Stderr, "skipping test that requires root")
 		os.Exit(0)
 	}
-	if 0 != os.Getuid() {
+	if os.Getuid() != 0 {
 		fmt.Fprintln(os.Stderr, "This test must be run as root.")
 		os.Exit(1)
 	}
diff --git a/plugin/plugin.go b/plugin/plugin.go
@@ -42,10 +42,7 @@ var (
 
 // IsSkipPlugin returns true if the error is skipping the plugin
 func IsSkipPlugin(err error) bool {
-	if errors.Cause(err) == ErrSkipPlugin {
-		return true
-	}
-	return false
+	return errors.Cause(err) == ErrSkipPlugin
 }
 
 // Type is the type of the plugin
diff --git a/remotes/docker/auth.go b/remotes/docker/auth.go
@@ -79,8 +79,8 @@ func init() {
 		var t octetType
 		isCtl := c <= 31 || c == 127
 		isChar := 0 <= c && c <= 127
-		isSeparator := strings.IndexRune(" \t\"(),/:;<=>?@[]\\{}", rune(c)) >= 0
-		if strings.IndexRune(" \t\r\n", rune(c)) >= 0 {
+		isSeparator := strings.ContainsRune(" \t\"(),/:;<=>?@[]\\{}", rune(c))
+		if strings.ContainsRune(" \t\r\n", rune(c)) {
 			t |= isSpace
 		}
 		if isChar && !isCtl && !isSeparator {
diff --git a/runtime/v2/shim/shim_unix.go b/runtime/v2/shim/shim_unix.go
@@ -72,9 +72,9 @@ func serveListener(path string) (net.Listener, error) {
 
 func handleSignals(logger *logrus.Entry, signals chan os.Signal) error {
 	logger.Info("starting signal loop")
+
 	for {
-		select {
-		case s := <-signals:
+		for s := range signals {
 			switch s {
 			case unix.SIGCHLD:
 				if err := Reap(); err != nil {
diff --git a/runtime/v2/shim/shim_windows.go b/runtime/v2/shim/shim_windows.go
@@ -113,12 +113,11 @@ func serveListener(path string) (net.Listener, error) {
 
 func handleSignals(logger *logrus.Entry, signals chan os.Signal) error {
 	logger.Info("starting signal loop")
+
 	for {
-		select {
-		case s := <-signals:
+		for s := range signals {
 			switch s {
 			case os.Interrupt:
-				break
 			}
 		}
 	}
diff --git a/runtime/v2/shim/util_windows.go b/runtime/v2/shim/util_windows.go
@@ -54,7 +54,7 @@ func AnonDialer(address string, timeout time.Duration) (net.Conn, error) {
 	timedOutError := errors.Errorf("timed out waiting for npipe %s", address)
 	start := time.Now()
 	for {
-		remaining := timeout - time.Now().Sub(start)
+		remaining := timeout - time.Since(start)
 		if remaining <= 0 {
 			lastError = timedOutError
 			break
@@ -71,7 +71,7 @@ func AnonDialer(address string, timeout time.Duration) (net.Conn, error) {
 		// serve it within 5 seconds. We use the passed in timeout for the
 		// `DialPipe` timeout if the pipe exists however to give the pipe time
 		// to `Accept` the connection.
-		if time.Now().Sub(start) >= 5*time.Second {
+		if time.Since(start) >= 5*time.Second {
 			lastError = timedOutError
 			break
 		}
diff --git a/services/containers/local.go b/services/containers/local.go
@@ -147,9 +147,7 @@ func (l *local) Update(ctx context.Context, req *api.UpdateContainerRequest, _ .
 	if err := l.withStoreUpdate(ctx, func(ctx context.Context, store containers.Store) error {
 		var fieldpaths []string
 		if req.UpdateMask != nil && len(req.UpdateMask.Paths) > 0 {
-			for _, path := range req.UpdateMask.Paths {
-				fieldpaths = append(fieldpaths, path)
-			}
+			fieldpaths = append(fieldpaths, req.UpdateMask.Paths...)
 		}
 
 		updated, err := store.Update(ctx, container, fieldpaths...)
diff --git a/services/images/local.go b/services/images/local.go
@@ -137,9 +137,7 @@ func (l *local) Update(ctx context.Context, req *imagesapi.UpdateImageRequest, _
 	)
 
 	if req.UpdateMask != nil && len(req.UpdateMask.Paths) > 0 {
-		for _, path := range req.UpdateMask.Paths {
-			fieldpaths = append(fieldpaths, path)
-		}
+		fieldpaths = append(fieldpaths, req.UpdateMask.Paths...)
 	}
 
 	updated, err := l.store.Update(ctx, image, fieldpaths...)

Original file line number	Diff line number	Diff line change
`@@ -295,7 +295,7 @@ func applyNaive(ctx context.Context, root string, tr *tar.Reader, options ApplyO`
`295`	`295`	`linkBasename := filepath.Base(hdr.Linkname)`
`296`	`296`	`srcHdr = aufsHardlinks[linkBasename]`
`297`	`297`	`if srcHdr == nil {`
`298`		`- return 0, fmt.Errorf("Invalid aufs hardlink")`
	`298`	`+ return 0, fmt.Errorf("invalid aufs hardlink")`
`299`	`299`	`}`
`300`	`300`	`p, err := fs.RootPath(aufsTempdir, linkBasename)`
`301`	`301`	`if err != nil {`
Original file line number	Diff line number	Diff line change
`@@ -283,7 +283,7 @@ func TestBreakouts(t *testing.T) {`
`283`	`283`	`if err != nil {`
`284`	`284`	`return err`
`285`	`285`	`}`
`286`		`- if bytes.Compare(b, content) != 0 {`
	`286`	`+ if !bytes.Equal(b, content) {`
`287`	`287`	`return errors.Errorf("content differs: expected %v, got %v", content, b)`
`288`	`288`	`}`
`289`	`289`	`return nil`
`@@ -1133,7 +1133,7 @@ func fileEntry(name string, expected []byte, mode int) tarEntryValidator {`
`1133`	`1133`	`if hdr.Mode != int64(mode) {`
`1134`	`1134`	`return errors.Errorf("wrong mode %o, expected %o", hdr.Mode, mode)`
`1135`	`1135`	`}`
`1136`		`- if bytes.Compare(b, expected) != 0 {`
	`1136`	`+ if !bytes.Equal(b, expected) {`
`1137`	`1137`	`return errors.Errorf("different file content")`
`1138`	`1138`	`}`
`1139`	`1139`	`return nil`
Original file line number	Diff line number	Diff line change
`@@ -911,7 +911,7 @@ func TestDaemonRestartWithRunningShim(t *testing.T) {`
`911`	`911`	`}`
`912`	`912`
`913`	`913`	`pid := task.Pid()`
`914`		`- if pid <= 0 {`
	`914`	`+ if pid < 1 {`
`915`	`915`	`t.Fatalf("invalid task pid %d", pid)`
`916`	`916`	`}`
`917`	`917`
`@@ -1201,7 +1201,7 @@ func testUserNamespaces(t *testing.T, readonlyRootFS bool) {`
`1201`	`1201`	`t.Fatal(err)`
`1202`	`1202`	`}`
`1203`	`1203`
`1204`		`- if pid := task.Pid(); pid <= 0 {`
	`1204`	`+ if pid := task.Pid(); pid < 1 {`
`1205`	`1205`	`t.Errorf("invalid task pid %d", pid)`
`1206`	`1206`	`}`
`1207`	`1207`	`if err := task.Start(ctx); err != nil {`
Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,7 @@ func TestContainerStart(t *testing.T) {`
`136`	`136`	`t.Fatal(err)`
`137`	`137`	`}`
`138`	`138`
`139`		`- if pid := task.Pid(); pid <= 0 {`
	`139`	`+ if pid := task.Pid(); pid < 1 {`
`140`	`140`	`t.Errorf("invalid task pid %d", pid)`
`141`	`141`	`}`
`142`	`142`	`if err := task.Start(ctx); err != nil {`
`@@ -435,7 +435,7 @@ func TestContainerPids(t *testing.T) {`
`435`	`435`	`}`
`436`	`436`
`437`	`437`	`pid := task.Pid()`
`438`		`- if pid <= 0 {`
	`438`	`+ if pid < 1 {`
`439`	`439`	`t.Errorf("invalid task pid %d", pid)`
`440`	`440`	`}`
`441`	`441`	`processes, err := task.Pids(ctx)`
`@@ -785,7 +785,7 @@ func TestWaitStoppedTask(t *testing.T) {`
`785`	`785`	`t.Fatal(err)`
`786`	`786`	`}`
`787`	`787`
`788`		`- if pid := task.Pid(); pid <= 0 {`
	`788`	`+ if pid := task.Pid(); pid < 1 {`
`789`	`789`	`t.Errorf("invalid task pid %d", pid)`
`790`	`790`	`}`
`791`	`791`	`if err := task.Start(ctx); err != nil {`
Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,5 @@ func unlock(ref string) {`
`47`	`47`	`locksMu.Lock()`
`48`	`48`	`defer locksMu.Unlock()`
`49`	`49`
`50`		`- if _, ok := locks[ref]; ok {`
`51`		`- delete(locks, ref)`
`52`		`- }`
	`50`	`+ delete(locks, ref)`
`53`	`51`	`}`
Original file line number	Diff line number	Diff line change
`@@ -37,10 +37,10 @@ func WithProfile(profile string) oci.SpecOpts {`
`37`	`37`	`s.Linux.Seccomp = &specs.LinuxSeccomp{}`
`38`	`38`	`f, err := ioutil.ReadFile(profile)`
`39`	`39`	`if err != nil {`
`40`		`- return fmt.Errorf("Cannot load seccomp profile %q: %v", profile, err)`
	`40`	`+ return fmt.Errorf("cannot load seccomp profile %q: %v", profile, err)`
`41`	`41`	`}`
`42`	`42`	`if err := json.Unmarshal(f, s.Linux.Seccomp); err != nil {`
`43`		`- return fmt.Errorf("Decoding seccomp profile failed %q: %v", profile, err)`
	`43`	`+ return fmt.Errorf("decoding seccomp profile failed %q: %v", profile, err)`
`44`	`44`	`}`
`45`	`45`	`return nil`
`46`	`46`	`}`