Redesign cgp_type to work as attribute macro#68
Merged
soareschen merged 7 commits intomainfrom Feb 16, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR redesigns the
cgp_typemacro to make it an attribute macro following the same syntax ascgp_component. This is to allow for more complex CGP type components to be defined using the same macro, which may include generic parameters or super traits on the consumer trait.The main change is as follows:
Before:
After:
This PR also changes the implicit naming convention for the provider and component names. If no parameter is specified,
cgp_typewould use{Type}TypeProvideras the provider name, and{Type}TypeProviderComponentas the component name. So the above definition can also be made explicit with: