lang: allow `token::...` and `mint::...` to be used as checks without init #1505

0xquantech · 2022-02-22T17:04:42Z

I added token_account and mint in ConstraintGroup.

pub struct ConstraintGroup {
    init: Option<ConstraintInitGroup>,
    zeroed: Option<ConstraintZeroed>,
... ... ...
    associated_token: Option<ConstraintAssociatedToken>,
// newly added
    token_account: Option<ConstraintTokenAccountGroup>,
    mint: Option<ConstraintTokenMintGroup>,
}

#[derive(Debug, Clone)]
pub struct ConstraintTokenAccountGroup {
    pub mint: Option<Expr>,
    pub authority: Option<Expr>,
}

#[derive(Debug, Clone)]
pub struct ConstraintTokenMintGroup {
    pub decimals: Option<Expr>,
    pub mint_authority: Option<Expr>,
    pub freeze_authority: Option<Expr>,
}

Made some unit tests for test of token constraints in misc
i.e. for mint::decimals and mint::freeze_authority test

#[derive(Accounts)]
#[instruction(_decimals: u8)]
pub struct TestMintMissMintAuthConstraint<'info> {
    #[account(
        mint::decimals = _decimals,
        mint::freeze_authority = freeze_authority,
    )]
    pub mint: Account<'info, Mint>,
    #[account(mut)]
    pub payer: Signer<'info>,
    pub rent: Sysvar<'info, Rent>,
    pub system_program: AccountInfo<'info>,
    pub token_program: AccountInfo<'info>,
    pub freeze_authority: AccountInfo<'info>,
}

0xquantech · 2022-03-05T15:05:05Z

Hi, @paul-schaaf, Can you review this PR?

0xquantech · 2022-03-05T21:04:25Z

Hi, @fanatid, Can you review my PR?
I want to jump to #issue 695, but I am stuck here.

tests/misc/programs/misc/src/context.rs

lang/syn/src/lib.rs

lang/syn/src/parser/accounts/constraints.rs

tests/misc/tests/misc.js

lang/syn/src/parser/accounts/constraints.rs

.

paul-schaaf · 2022-03-07T17:14:57Z

the review dismissal was a missclick. pls do have a look at my comments :)

paul-schaaf · 2022-03-23T18:40:33Z

@blockchainlover2019 do you have time to finish this or do you want me to take over?

0xquantech · 2022-03-23T20:32:29Z

Sorry, @paul-schaaf , I have been very busy for MVP launch.
I will finish modification this week.

lang/syn/src/codegen/accounts/constraints.rs

lang/syn/src/parser/accounts/constraints.rs

tests/misc/tests/misc.ts

lang/syn/src/parser/accounts/constraints.rs

0xquantech · 2022-04-01T21:58:33Z

@paul-schaaf, I've finished modifying codes. I want to know your opinions. Please don't hesitate to tell me about the modification and other improvements. I feel good at working with you

tests/misc/tests/misc.ts

armaniferrante · 2022-04-08T17:49:58Z

tests/misc/tests/misc.ts

+        signers: [token],
+      });
+      try {
+        await program.rpc.testTokenConstraint({


we should stop using this api with new tests

though for now let's not worry about it and just get this in

Yeah, got it.
I think there should be a unit test framework to manage tests on Anchor framework.
misc.ts is so long in its codes.

yea we have issues to split up the misc tests and generally rework the testing for anchor itself

lang/syn/src/codegen/accounts/constraints.rs

paul-schaaf · 2022-04-11T17:42:42Z

hey @blockchainlover2019 we want to release today and would like to include this PR so Im going to finish it now

0xquantech · 2022-04-11T17:46:55Z

hey @blockchainlover2019 we want to release today and would like to include this PR so Im going to finish it now

Okay!

fanatid · 2022-04-11T18:24:27Z

lang/syn/src/parser/accounts/constraints.rs

+                freeze_authority: mint_freeze_authority
+                    .as_ref()
+                    .map(|a| a.clone().into_inner().mint_freeze_auth),


Suggested change

freeze_authority: mint_freeze_authority

.as_ref()

.map(|a| a.clone().into_inner().mint_freeze_auth),

freeze_authority: mint_freeze_authority.cloned().map(|a| a.into_inner().mint_freeze_auth),

Can be simpler 🙂
But current also looks good!

that doesnt actually work because cloned only exists on Option<&T> (and Option<&mut T>) but mint_freeze_authority is an Option<T>. could do clone().map() but I like my solution more than that

paul-schaaf · 2022-04-11T21:25:19Z

thanks for the contribution @blockchainlover2019 !

0xquantech · 2022-04-12T01:22:23Z

I feel happy to contribute, and in the opposite, I feel bad about not finishing work quickly and wonderfully.
I started learning solana from your blog and learning a lot from you guys - @paul-schaaf, @armaniferrante, @fanatid.
Thank you guys!

0xquantech mentioned this pull request Feb 25, 2022

lang: allow token::.. and mint::... to be used as checks without init #1222

Closed

0xquantech changed the title ~~Add TokenConstraint feature and Constraint unit test~~ lang: allow token::.. and mint::... to be used as checks without init Feb 27, 2022

0xquantech changed the title ~~lang: allow token::.. and mint::... to be used as checks without init~~ lang: allow token::.. and mint::... to be used as checks without init Feb 27, 2022

0xquantech changed the title ~~lang: allow token::.. and mint::... to be used as checks without init~~ lang: allow token::.. and mint::... to be used as checks without init Feb 27, 2022

0xquantech changed the title ~~lang: allow token::.. and mint::... to be used as checks without init~~ lang: allow token::.. and mint::... to be used as checks without init Feb 27, 2022

0xquantech changed the title ~~lang: allow token::.. and mint::... to be used as checks without init~~ lang: allow *token::..* and mint::... to be used as checks without init Feb 27, 2022

0xquantech changed the title ~~lang: allow *token::..* and mint::... to be used as checks without init~~ lang: allow token::.. and mint::... to be used as checks without init Feb 27, 2022

0xquantech changed the title ~~lang: allow token::.. and mint::... to be used as checks without init~~ lang: allow token::.. and mint::... to be used as checks without init Feb 27, 2022

0xquantech changed the title ~~lang: allow token::.. and mint::... to be used as checks without init~~ lang: allow token::.. and mint::... to be used as checks without init Feb 27, 2022

0xquantech changed the title ~~lang: allow token::.. and mint::... to be used as checks without init~~ lang: allow token::... and mint::... to be used as checks without init Feb 27, 2022

paul-schaaf previously requested changes Mar 7, 2022

View reviewed changes

0xquantech added 2 commits March 28, 2022 18:48

Add TokenConstraint feature and Constraint unit test

04d81be

Modify some spellings and fix logic

0f1fe02

paul-schaaf reviewed Mar 31, 2022

View reviewed changes

lang/syn/src/codegen/accounts/constraints.rs Outdated Show resolved Hide resolved

lang/syn/src/parser/accounts/constraints.rs Show resolved Hide resolved

tests/misc/tests/misc.ts Outdated Show resolved Hide resolved

lang/syn/src/parser/accounts/constraints.rs Show resolved Hide resolved

Make improvments

b2916bb

paul-schaaf reviewed Apr 4, 2022

View reviewed changes

tests/misc/tests/misc.ts Show resolved Hide resolved

Add error code checks

26be25d

paul-schaaf mentioned this pull request Apr 8, 2022

lang: group constraints that belong together #1212

Open

armaniferrante reviewed Apr 8, 2022

View reviewed changes

armaniferrante reviewed Apr 9, 2022

View reviewed changes

lang/syn/src/codegen/accounts/constraints.rs Outdated Show resolved Hide resolved

armaniferrante reviewed Apr 9, 2022

View reviewed changes

lang/syn/src/codegen/accounts/constraints.rs Outdated Show resolved Hide resolved

paul-schaaf added 2 commits April 11, 2022 13:55

lang/tests: review comments

63ad92b

Merge branch 'master' into anan/anchor-lang-issue#1222

bf5ec2b

fanatid reviewed Apr 11, 2022

View reviewed changes

paul-schaaf added 5 commits April 11, 2022 14:35

tests: adjust compute units

20651d4

docs

6d3887f

tests: remove unnecessary accounts

a0abcd7

Merge branch 'master' into anan/anchor-lang-issue#1222

97488c6

tests: fix misc

d0be41b

paul-schaaf merged commit f5dffe6 into coral-xyz:master Apr 11, 2022

lincot mentioned this pull request Jun 10, 2022

Docs incorrectly state that token::mint & token::authority can be used without init #1961

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lang: allow `token::...` and `mint::...` to be used as checks without init #1505

lang: allow `token::...` and `mint::...` to be used as checks without init #1505

0xquantech commented Feb 22, 2022 •

edited

Loading

0xquantech commented Mar 5, 2022

0xquantech commented Mar 5, 2022 •

edited

Loading

paul-schaaf commented Mar 7, 2022

paul-schaaf commented Mar 23, 2022

0xquantech commented Mar 23, 2022

0xquantech commented Apr 1, 2022

armaniferrante Apr 8, 2022

armaniferrante Apr 8, 2022

0xquantech Apr 8, 2022

paul-schaaf Apr 8, 2022

paul-schaaf commented Apr 11, 2022

0xquantech commented Apr 11, 2022 •

edited

Loading

fanatid Apr 11, 2022

0xquantech Apr 11, 2022

paul-schaaf Apr 11, 2022 •

edited

Loading

paul-schaaf commented Apr 11, 2022

0xquantech commented Apr 12, 2022 •

edited

Loading

lang: allow token::... and mint::... to be used as checks without init #1505

lang: allow token::... and mint::... to be used as checks without init #1505

Conversation

0xquantech commented Feb 22, 2022 • edited Loading

0xquantech commented Mar 5, 2022

0xquantech commented Mar 5, 2022 • edited Loading

paul-schaaf commented Mar 7, 2022

paul-schaaf commented Mar 23, 2022

0xquantech commented Mar 23, 2022

0xquantech commented Apr 1, 2022

armaniferrante Apr 8, 2022

Choose a reason for hiding this comment

armaniferrante Apr 8, 2022

Choose a reason for hiding this comment

0xquantech Apr 8, 2022

Choose a reason for hiding this comment

paul-schaaf Apr 8, 2022

Choose a reason for hiding this comment

paul-schaaf commented Apr 11, 2022

0xquantech commented Apr 11, 2022 • edited Loading

fanatid Apr 11, 2022

Choose a reason for hiding this comment

0xquantech Apr 11, 2022

Choose a reason for hiding this comment

paul-schaaf Apr 11, 2022 • edited Loading

Choose a reason for hiding this comment

paul-schaaf commented Apr 11, 2022

0xquantech commented Apr 12, 2022 • edited Loading

lang: allow `token::...` and `mint::...` to be used as checks without init #1505

lang: allow `token::...` and `mint::...` to be used as checks without init #1505

0xquantech commented Feb 22, 2022 •

edited

Loading

0xquantech commented Mar 5, 2022 •

edited

Loading

0xquantech commented Apr 11, 2022 •

edited

Loading

paul-schaaf Apr 11, 2022 •

edited

Loading

0xquantech commented Apr 12, 2022 •

edited

Loading