Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: confluentinc/confluent-kafka-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: csdisco/confluent-kafka-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 13 files changed
  • 1 contributor

Commits on Jul 23, 2018

  1. Configuration menu
    Copy the full SHA
    72ac392 View commit details
    Browse the repository at this point in the history
  2. Subject name strategy (#4)

    * Mirror subject.name.strategy from Java client
    
    Provides a means to configure a subject name strategy for both key and value when using
    the schema registry.  This brings the python client in line with the java client, and
    enables the use of multiple schemas on a single topic.
    
    * PR Feedback, round 1
    * Remove plugin registration and lookup
    * Remove interface in favor of callback
    
    * Remove whitespaces to pass flake check
    
    * PR Feedback, round 2
    * Add integration tests
    * Fix potential issue using RecordNameStrategy with primitive or null schemas
    
    * PR Feedback, Round 2
    * Move serializer setter below superclass ctor call
    delphyne committed Jul 23, 2018
    Configuration menu
    Copy the full SHA
    1de70c7 View commit details
    Browse the repository at this point in the history
  3. Avro schema on consumer poll (#5)

    * Optionally return schemas with AvroProducer #289
    
    When calling poll, with_schemas kwarg may be provided to return a proxy for the message.  That proxy includes both the key_schema and value_schema as properties.  The raw message is also available as a property, and all other calls are delegated to the message.
    
    * Fix long line in comment
    delphyne committed Jul 23, 2018
    Configuration menu
    Copy the full SHA
    f890d2f View commit details
    Browse the repository at this point in the history
Loading