Add a dropdown to display/hide columns in Datatable#1118
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1118 +/- ##
=======================================
Coverage 71.35% 71.35%
=======================================
Files 63 63
Lines 4151 4151
=======================================
Hits 2962 2962
Misses 1189 1189 🚀 New features to boost your workflow:
|
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
bc/datatable-improvement
|
| Run status |
|
| Run duration | 06m 32s |
| Commit |
|
| Committer | Ben Charmes |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
166
|
| View all changes introduced in this branch ↗︎ | |
9120bc4 to
2d649e1
Compare
26c8eb7 to
54ea566
Compare
ml-evs
left a comment
There was a problem hiding this comment.
Looks really nice to me @BenjaminCharmes! Anything else you want to add before merging? I'm also wondering if we should always force the ID/type column to be there
54ea566 to
7d6dc1f
Compare
From my side, it's ready to merge! |
Co-authored-by: Matthew Evans <git@ml-evs.science>
988badc to
777cfdf
Compare
Remove unused template Remove unused template Remove unused template
e27182b to
0fe2157
Compare
ml-evs
left a comment
There was a problem hiding this comment.
LGTM, thanks @BenjaminCharmes!
| .p-multiselect-header .p-checkbox::after { | ||
| content: 'Select all'; | ||
| position: absolute; | ||
| left: 28px; | ||
| width: 110px; | ||
| } |
There was a problem hiding this comment.
Unfortunately this was the only way I found of doing it too! We might think about using rem rather than px to be slightly more transferable here, but it looks fine at all resolutions I try it at (presumably primevue has some hardcoded pixel values too)
Co-authored-by: Matthew Evans <git@ml-evs.science>
Closes #1117