Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tightening uniqueness constraints on item_ids #241

Open
ml-evs opened this issue Jan 24, 2023 · 1 comment
Open

Tightening uniqueness constraints on item_ids #241

ml-evs opened this issue Jan 24, 2023 · 1 comment
Assignees
Milestone

Comments

@ml-evs
Copy link
Member

ml-evs commented Jan 24, 2023

Pushing the discussion one step further, we should consider reinterpreting unique "ID" to mean that the same ID with dash/underscores/capitalisation is not allowed, e.g.,

jdb_2 should block JDB-2 and JdB_2. Ideally we could encode this at the MongoDB index level (I think you can do case-insensitive indexes quit readily, not sure about - vs _).

Originally posted by @ml-evs in #239 (comment)

@ml-evs ml-evs assigned ml-evs and jdbocarsly and unassigned jdbocarsly Jan 24, 2023
@ml-evs ml-evs modified the milestones: v0.2, v0.3 Jan 25, 2023
@ml-evs
Copy link
Member Author

ml-evs commented Jan 29, 2023

Just ran into "." in IDs on the deployment which are now banned. There was only one item with this problem so I just casually renamed it for now. Probably also need to validate things like _____ as an ID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants