Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI tweaks and refactors #291

Merged
merged 1 commit into from
Feb 15, 2023
Merged

UI tweaks and refactors #291

merged 1 commit into from
Feb 15, 2023

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Feb 7, 2023 •
edited
Loading

This PR adds several UI tweaks:

  • Use GitHub icons everywhere we link to a repo
  • Sparingly use icons for sample creation, login and logout
  • Refactor creators component and use it within sample page
  • Use formatted ID labels in item tables
  • Fixes occurences of datalabvue

Closes #277 and #262

@ml-evs ml-evs requested a review from jdbocarsly as a code owner February 7, 2023 23:17
@ml-evs ml-evs force-pushed the ml-evs/add_more_fa_icons branch from 8347af9 to c2b99e4 Compare February 7, 2023 23:19
@cypress
Copy link

cypress bot commented Feb 7, 2023 •
edited
Loading

Passing run #89 ↗︎

0 45 0 0 Flakiness 0

Details:

Merge 3024b31 into d0575a0...
Project: datalab Commit: 47914fb416 ℹ️
Status: Passed Duration: 06:01 💡
Started: Feb 15, 2023 4:18 PM Ended: Feb 15, 2023 4:24 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@ml-evs ml-evs mentioned this pull request Feb 8, 2023
Closed
@ml-evs ml-evs changed the title Add more icons UI tweaks and refactors Feb 14, 2023
@ml-evs ml-evs force-pushed the ml-evs/add_more_fa_icons branch 8 times, most recently from ea628b3 to 3024b31 Compare February 15, 2023 16:08
@ml-evs
UI tweaks
163b26b 
- Add more fontawesome icons

- Remove some occurences of datalabvue

- Pare back some of the icons

- Use GitHub logo and link to docs in about page

- Try to use yarn.lock from docker build directly

- Centre title in way that doesn't break mkdocs

- Remove remaining mentions of 'datalabvue'

- Use formatted item IDs in sample and starting material tables

- Tweak spacing in navbar

- Separate out user and creators components

- Add creator component to SampleInformation

- Update yarn lockfile with yarn 1.22.19

- Update unit test snapshots
@ml-evs ml-evs force-pushed the ml-evs/add_more_fa_icons branch from 3024b31 to 163b26b Compare February 15, 2023 18:15
@ml-evs ml-evs merged commit 9a20052 into main Feb 15, 2023
@ml-evs ml-evs deleted the ml-evs/add_more_fa_icons branch February 15, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdbocarsly jdbocarsly Awaiting requested review from jdbocarsly jdbocarsly is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggestion: rename "Starting Materials" on main page
1 participant
@ml-evs