Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Bootstrap 5 #32

Open
jdbocarsly opened this issue Jul 26, 2021 · 0 comments · May be fixed by #1028
Open

Update to Bootstrap 5 #32

jdbocarsly opened this issue Jul 26, 2021 · 0 comments · May be fixed by #1028
Assignees
@jdbocarsly
Labels
dependency_updates For issues/PRs that update the dependencies of the package webapp For issues/PRs pertaining to the web interface

Comments

@jdbocarsly
Copy link
Member

The webapp is currently using Bootstrap 4 without a JS interaction library, since Bootstrap 4 JS relies on Jquery which we do not want to use in the app. BootstrapVue would solve this, but it does not support Vue3.

Upgrading to Bootstrap 5 will solve this issue, as it uses pure JS for its interactions. We should also be able to choose which js to include (if any).
@jdbocarsly jdbocarsly added dependency_updates For issues/PRs that update the dependencies of the package webapp For issues/PRs pertaining to the web interface labels Jul 26, 2021
@jdbocarsly jdbocarsly self-assigned this Nov 5, 2021
@jdbocarsly jdbocarsly mentioned this issue Feb 28, 2024
Open
This was referenced Dec 2, 2024
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdbocarsly jdbocarsly

Labels
dependency_updates For issues/PRs that update the dependencies of the package webapp For issues/PRs pertaining to the web interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to Bootstrap v5 datalab-org/datalab
1 participant
@jdbocarsly