datasette-create-view for datasette>=1.0a20

Refs simonw/datasette#2577

Author: simonw

datasette_create_view/__init__.py

@@ -1,4 +1,5 @@
 from datasette import hookimpl, Response
+from datasette.resources import DatabaseResource
 from datasette.utils import derive_named_parameters
 import urllib
 
@@ -14,8 +15,11 @@ async def inner():
         if parameters:
             return
         # User must have create-table permission
-        if not await datasette.permission_allowed(
-            actor, "create-table", resource=database
+        database_resource = DatabaseResource(database)
+        if not await datasette.allowed(
+            actor=actor,
+            action="create-table",
+            resource=database_resource,
         ):
             return
         return [
@@ -38,6 +42,7 @@ async def inner():
 async def create_view(request, datasette):
     database = request.url_vars["database"]
     db = datasette.get_database(database)
+    database_resource = DatabaseResource(database)
     if request.method == "POST":
         post_vars = await request.post_vars()
         sql = (post_vars.get("sql") or "").strip()
@@ -52,8 +57,10 @@ async def create_view(request, datasette):
                 }
             )
         )
-        if not await datasette.permission_allowed(
-            request.actor, "create-table", resource=database
+        if not await datasette.allowed(
+            actor=request.actor,
+            action="create-table",
+            resource=database_resource,
         ):
             datasette.add_message(
                 request,

pyproject.toml

@@ -4,14 +4,13 @@ version = "0.1a1"
 description = "Create a SQL view from a query"
 readme = "README.md"
 authors = [{name = "Simon Willison"}]
-license = {text = "Apache-2.0"}
+license = "Apache-2.0"
 classifiers=[
-    "Framework :: Datasette",
-    "License :: OSI Approved :: Apache Software License"
+    "Framework :: Datasette"
 ]
-requires-python = ">=3.8"
+requires-python = ">=3.10"
 dependencies = [
-    "datasette==1.0a19"
+    "datasette>=1.0a21"
 ]
 
 [project.urls]

tests/test_create_view.py

@@ -14,6 +14,7 @@
 )
 async def test_query_action_menu(actor, sql, should_see_option):
     datasette = Datasette()
+    datasette.root_enabled = True
     db = datasette.add_memory_database("test")
     cookies = {}
     if actor:
@@ -56,6 +57,7 @@ async def test_query_action_menu(actor, sql, should_see_option):
 async def test_create_view_errors(actor, args, expected_error):
     # Get csfrtoken
     datasette = Datasette()
+    datasette.root_enabled = True
     db = datasette.add_memory_database("test")
     cookies = {}
     if actor:
@@ -79,6 +81,7 @@ async def test_create_view_errors(actor, args, expected_error):
 @pytest.mark.asyncio
 async def test_happy_path():
     datasette = Datasette()
+    datasette.root_enabled = True
     db = datasette.add_memory_database("test")
     cookies = {"ds_actor": datasette.client.actor_cookie({"id": "root"})}
     get_response = await datasette.client.get("/test/-/create-view", cookies=cookies)