Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valkey as additional service - redis alternative #28

Open
1 task done
friedinando opened this issue Nov 8, 2024 · 3 comments
Open
1 task done

Valkey as additional service - redis alternative #28

friedinando opened this issue Nov 8, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@friedinando
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem?

https://www.linuxfoundation.org/press/linux-foundation-launches-open-source-valkey-community

Describe your solution

https://www.drupal.org/project/redis/issues/3443819

Describe alternatives

No response

Additional context

No response

@friedinando friedinando added the enhancement New feature or request label Nov 8, 2024
@friedinando friedinando changed the title Valley as additional service - redis alternative Valkey as additional service - redis alternative Nov 8, 2024
@rfay
Copy link
Member

rfay commented Nov 8, 2024

Hi @friedinando - Why don't you fork https://github.com/ddev/redis and create a new add-on using valkey. I imagine it's pretty straightforward. Another option would be a PR to make valkey an option on the redis PR.

@rfay rfay transferred this issue from ddev/ddev Nov 8, 2024
@rfay
Copy link
Member

rfay commented Nov 8, 2024

I moved this issue to the ddev-redis add-on repo, it's worthy of conversation here.

@stasadev
Copy link
Member

stasadev commented Nov 8, 2024

They already have 17k stars https://github.com/valkey-io/valkey, we definitely should support Valkey.

I ran this to see what we have inside, and redis-server is available.

docker run --rm -it --name valkey valkey/valkey bash

We can replace this

image: redis:${REDIS_TAG:-6-bullseye}

with:

image: ${REDIS_IMAGE:-redis}:${REDIS_TAG:-6-bullseye} 

and update tests to check if Valkey is going to work.


But this reminds me of https://github.com/ddev/ddev-elasticsearch vs https://github.com/ddev/ddev-opensearch that already have some differences.

What if Valkey implements something new, then it's better to have a new add-on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants