We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https://www.linuxfoundation.org/press/linux-foundation-launches-open-source-valkey-community
https://www.drupal.org/project/redis/issues/3443819
No response
The text was updated successfully, but these errors were encountered:
Hi @friedinando - Why don't you fork https://github.com/ddev/redis and create a new add-on using valkey. I imagine it's pretty straightforward. Another option would be a PR to make valkey an option on the redis PR.
Sorry, something went wrong.
I moved this issue to the ddev-redis add-on repo, it's worthy of conversation here.
They already have 17k stars https://github.com/valkey-io/valkey, we definitely should support Valkey.
I ran this to see what we have inside, and redis-server is available.
redis-server
docker run --rm -it --name valkey valkey/valkey bash
We can replace this
ddev-redis/docker-compose.redis.yaml
Line 5 in 0147f41
with:
image: ${REDIS_IMAGE:-redis}:${REDIS_TAG:-6-bullseye}
and update tests to check if Valkey is going to work.
But this reminds me of https://github.com/ddev/ddev-elasticsearch vs https://github.com/ddev/ddev-opensearch that already have some differences.
What if Valkey implements something new, then it's better to have a new add-on.
No branches or pull requests
Is there an existing issue for this?
Is your feature request related to a problem?
https://www.linuxfoundation.org/press/linux-foundation-launches-open-source-valkey-community
Describe your solution
https://www.drupal.org/project/redis/issues/3443819
Describe alternatives
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: