Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExcludeDockerImages fails with missing 1 required positional argument: 'masks' #72

Closed
fuzzmz opened this issue Sep 26, 2022 · 4 comments

Comments

@fuzzmz
Copy link

fuzzmz commented Sep 26, 2022

The following config fails with

Check failed for rule 'ExcludeDockerImages' in policy 'Remove docker images, but keep last 10':
check() missing 1 required positional argument: 'masks'

Relevant part of artifactory-cleanup.yaml

  policies:
    - name: Remove docker images, but keep last 10
      rules:
        # Select repo
        - rule: Repo
          name: docker-local
        # Keep these tags for all images
        - rule: ExcludeDockerImages
          masks:
            - "*:latest"
            - "*:release*"
@atalakey4work
Copy link

Facing the same issue here

@fuzzmz
Copy link
Author

fuzzmz commented Sep 27, 2022

@atalakey4work, this is going to be fixed in #73.

@allburov
Copy link
Member

allburov commented Sep 27, 2022

@fuzzmz thank you for mentioning the fix! Looking at this

Please do not suggest manual patching, it's not the best choose for the future support ;)

allburov pushed a commit that referenced this issue Sep 27, 2022
@allburov
Copy link
Member

Fixed in https://github.com/devopshq/artifactory-cleanup/releases/tag/1.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants