Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RepoList #89

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Fix RepoList #89

merged 1 commit into from
Dec 16, 2022

Conversation

sm-gravid-day
Copy link
Contributor

Fixes #87

@sm-gravid-day sm-gravid-day mentioned this pull request Dec 15, 2022
Closed
@allburov allburov merged commit 466365a into devopshq:master Dec 16, 2022
@allburov
Copy link
Member

allburov commented Dec 16, 2022 •
edited
Loading

@sm-gravid-day thank you for fixing this!

It's bad that we don't have tests that cover all cases properly :(

@sm-gravid-day sm-gravid-day deleted the fix-RepoList branch December 16, 2022 10:58
@sm-gravid-day
Copy link
Contributor Author

@allburov thank you for such a quick review.

You're right about the test coverage, so I've made #90 - please take a look.

With these changes 3 of the unit tests fail with the old RepoList behaviour before my fix - so hopefully we should never see such an issue again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Formatting Question - RepoList
2 participants
@sm-gravid-day @allburov