Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#99 : output to json format #100

Merged
merged 2 commits into from
Mar 30, 2023
Merged

#99 : output to json format #100

merged 2 commits into from
Mar 30, 2023

Conversation

Turiok
Copy link
Contributor

@Turiok Turiok commented Mar 17, 2023 •
edited
Loading

Hi @allburov ,

I add 2 options to the cli. The output path and the output-format.
I tested it and modify the README.

Tell me if it has something wrong.

If you're agree, I would add a detailed option to display deleted files in the output. But It('ll be another PR.

Closes #99

@Turiok Turiok changed the title 99 : output to json format #99 : output to json format Mar 17, 2023
allburov
allburov requested changes Mar 17, 2023
View reviewed changes
Copy link
Member

@allburov allburov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes and we're good to go!

artifactory_cleanup/cli.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/test_cli.py Outdated Show resolved Hide resolved
tests/test_cli.py Outdated Show resolved Hide resolved
tests/test_cli.py Outdated Show resolved Hide resolved
allburov
allburov reviewed Mar 21, 2023
View reviewed changes
tests/conftest.py Outdated Show resolved Hide resolved
allburov
allburov reviewed Mar 21, 2023
View reviewed changes
tests/test_cli.py Outdated Show resolved Hide resolved
@Turiok Turiok force-pushed the feature/99_output_json branch 4 times, most recently from b12fe25 to 6216382 Compare March 22, 2023 18:30
@Turiok
Copy link
Contributor Author

Turiok commented Mar 22, 2023

Hi @allburov

Sorry if I'm annoying.
Thanks for explaining all these points, I learn a lot of things related to Python and Pytest thanks to you.

Our goals are multiple but each time the idea is to put the information in an ELK stack and in HTML pages

@Turiok Turiok force-pushed the feature/99_output_json branch 3 times, most recently from cce3386 to d45e895 Compare March 23, 2023 05:44
@allburov
Copy link
Member

@Turiok hi, no worries!
Sorry I'm so picky :D

allburov
allburov requested changes Mar 24, 2023
View reviewed changes
tests/test_cli.py Outdated Show resolved Hide resolved
@allburov
Copy link
Member

Good work!

@allburov allburov merged commit 7ff346a into devopshq:master Mar 30, 2023
@Turiok Turiok deleted the feature/99_output_json branch April 12, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allburov allburov allburov requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Output format to Json
2 participants
@Turiok @allburov