Skip to content

Commit f4dbe4b

Browse files
committed
Remove duplicate image env vars and constants
This fixes a 'Found conflicts when setting relatedImages' that could occur when building bundle's with USE_IMAGE_DIGESTS=true. Also, Adds missing .prow_ci.env. This will enable prow jobs to build with USE_IMAGE_DIGESTS
1 parent 216c203 commit f4dbe4b

5 files changed

Lines changed: 5 additions & 12 deletions

File tree

.prow_ci.env

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
export USE_IMAGE_DIGESTS=true

api/v1beta1/ceilometercentral_types.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,6 @@ import (
2626
const (
2727
// CeilometerCentralContainerImage - default fall-back image for Ceilometer Central
2828
CeilometerCentralContainerImage = "quay.io/podified-antelope-centos9/openstack-ceilometer-central:current-podified"
29-
// CeilometerCentralInitContainerImage - default fall-back image for Ceilometer Central Init
30-
CeilometerCentralInitContainerImage = "quay.io/podified-antelope-centos9/openstack-ceilometer-central:current-podified"
3129
// CeilometerNotificationContainerImage - default fall-back image for Ceilometer Notifcation
3230
CeilometerNotificationContainerImage = "quay.io/podified-antelope-centos9/openstack-ceilometer-notification:current-podified"
3331
// CeilometerSgCoreContainerImage - default fall-back image for Ceilometer SgCore
@@ -149,7 +147,7 @@ func SetupDefaultsCeilometerCentral() {
149147
// Acquire environmental defaults and initialize Telemetry defaults with them
150148
ceilometercentralDefaults := CeilometerCentralDefaults{
151149
CentralContainerImageURL: util.GetEnvVar("RELATED_IMAGE_CEILOMETER_CENTRAL_IMAGE_URL_DEFAULT", CeilometerCentralContainerImage),
152-
CentralInitContainerImageURL: util.GetEnvVar("RELATED_IMAGE_CEILOMETER_CENTRAL_INIT_IMAGE_URL_DEFAULT", CeilometerCentralInitContainerImage),
150+
CentralInitContainerImageURL: util.GetEnvVar("RELATED_IMAGE_CEILOMETER_CENTRAL_IMAGE_URL_DEFAULT", CeilometerCentralContainerImage),
153151
SgCoreContainerImageURL: util.GetEnvVar("RELATED_IMAGE_CEILOMETER_SGCORE_IMAGE_URL_DEFAULT", CeilometerSgCoreContainerImage),
154152
NotificationContainerImageURL: util.GetEnvVar("RELATED_IMAGE_CEILOMETER_NOTIFICATION_IMAGE_URL_DEFAULT", CeilometerNotificationContainerImage),
155153
}

api/v1beta1/ceilometercompute_types.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,6 @@ import (
2626
const (
2727
// CeilometerComputeContainerImage - default fall-back image for Ceilometer Compute
2828
CeilometerComputeContainerImage = "quay.io/podified-antelope-centos9/openstack-ceilometer-compute:current-podified"
29-
// CeilometerComputeInitContainerImage - default fall-back image for Ceilometer Compute Init
30-
CeilometerComputeInitContainerImage = "quay.io/podified-antelope-centos9/openstack-ceilometer-compute:current-podified"
3129
// CeilometerIpmiContainerImage - default fall-back image for Ceilometer Ipmi
3230
CeilometerIpmiContainerImage = "quay.io/podified-antelope-centos9/openstack-ceilometer-ipmi:current-podified"
3331
)
@@ -153,7 +151,7 @@ func SetupDefaultsCeilometerCompute() {
153151
// Acquire environmental defaults and initialize Telemetry defaults with them
154152
ceilometercomputeDefaults := CeilometerComputeDefaults{
155153
ComputeContainerImageURL: util.GetEnvVar("RELATED_IMAGE_CEILOMETER_COMPUTE_IMAGE_URL_DEFAULT", CeilometerComputeContainerImage),
156-
ComputeInitContainerImageURL: util.GetEnvVar("RELATED_IMAGE_CEILOMETER_COMPUTE_INIT_IMAGE_URL_DEFAULT", CeilometerComputeInitContainerImage),
154+
ComputeInitContainerImageURL: util.GetEnvVar("RELATED_IMAGE_CEILOMETER_COMPUTE_IMAGE_URL_DEFAULT", CeilometerComputeContainerImage),
157155
IpmiContainerImageURL: util.GetEnvVar("RELATED_IMAGE_CEILOMETER_IPMI_IMAGE_URL_DEFAULT", CeilometerIpmiContainerImage),
158156
}
159157

api/v1beta1/telemetry_types.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,9 +99,9 @@ func SetupDefaultsTelemetry() {
9999
// Acquire environmental defaults and initialize Telemetry defaults with them
100100
telemetryDefaults := TelemetryDefaults{
101101
CentralContainerImageURL: util.GetEnvVar("RELATED_IMAGE_CEILOMETER_CENTRAL_IMAGE_URL_DEFAULT", CeilometerCentralContainerImage),
102-
CentralInitContainerImageURL: util.GetEnvVar("RELATED_IMAGE_CEILOMETER_CENTRAL_INIT_IMAGE_URL_DEFAULT", CeilometerCentralInitContainerImage),
102+
CentralInitContainerImageURL: util.GetEnvVar("RELATED_IMAGE_CEILOMETER_CENTRAL_INIT_IMAGE_URL_DEFAULT", CeilometerCentralContainerImage),
103103
ComputeContainerImageURL: util.GetEnvVar("RELATED_IMAGE_CEILOMETER_COMPUTE_IMAGE_URL_DEFAULT", CeilometerComputeContainerImage),
104-
ComputeInitContainerImageURL: util.GetEnvVar("RELATED_IMAGE_CEILOMETER_COMPUTE_INIT_IMAGE_URL_DEFAULT", CeilometerComputeInitContainerImage),
104+
ComputeInitContainerImageURL: util.GetEnvVar("RELATED_IMAGE_CEILOMETER_COMPUTE_INIT_IMAGE_URL_DEFAULT", CeilometerComputeContainerImage),
105105
IpmiContainerImageURL: util.GetEnvVar("RELATED_IMAGE_CEILOMETER_IPMI_IMAGE_URL_DEFAULT", CeilometerIpmiContainerImage),
106106
NotificationContainerImageURL: util.GetEnvVar("RELATED_IMAGE_CEILOMETER_NOTIFICATION_IMAGE_URL_DEFAULT", CeilometerNotificationContainerImage),
107107
NodeExporterContainerImageURL: util.GetEnvVar("RELATED_IMAGE_TELEMETRY_NODE_EXPORTER_IMAGE_URL_DEFAULT", NodeExporterContainerImage),

config/default/manager_default_images.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,8 @@ spec:
1313
env:
1414
- name: RELATED_IMAGE_CEILOMETER_CENTRAL_IMAGE_URL_DEFAULT
1515
value: quay.io/podified-antelope-centos9/openstack-ceilometer-central:current-podified
16-
- name: RELATED_IMAGE_CEILOMETER_CENTRAL_INIT_IMAGE_URL_DEFAULT
17-
value: quay.io/podified-antelope-centos9/openstack-ceilometer-central:current-podified
1816
- name: RELATED_IMAGE_CEILOMETER_COMPUTE_IMAGE_URL_DEFAULT
1917
value: quay.io/podified-antelope-centos9/openstack-ceilometer-compute:current-podified
20-
- name: RELATED_IMAGE_CEILOMETER_COMPUTE_INIT_IMAGE_URL_DEFAULT
21-
value: quay.io/podified-antelope-centos9/openstack-ceilometer-compute:current-podified
2218
- name: RELATED_IMAGE_CEILOMETER_NOTIFICATION_IMAGE_URL_DEFAULT
2319
value: quay.io/podified-antelope-centos9/openstack-ceilometer-notification:current-podified
2420
- name: RELATED_IMAGE_CEILOMETER_IPMI_IMAGE_URL_DEFAULT

0 commit comments

Comments
 (0)