Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try parsing unknown columns as '<f4' with name "Unknown" #73

Open
chatcannon opened this issue Jun 5, 2022 · 1 comment
Open

Try parsing unknown columns as '<f4' with name "Unknown" #73

chatcannon opened this issue Jun 5, 2022 · 1 comment
Assignees

Comments

@chatcannon
Copy link
Collaborator

Currently the Bio-Logic .mpr parser exits with an error if it encounters an unknown column ID. This made sense at the time of writing because I had no way of knowing the data type of the new column and thus how many bytes it would take up in the file.

Looking at the file history, it seems that all new columns added in the past three years have been '<f4' (32-bit float). https://github.com/echemdata/galvani/blame/master/galvani/BioLogic.py

This means that it is probably safe to assume that any new unknown columns will also be 32-bit floats. This will make it possible to load the file despite the presence of unknown columns.

@NuxitBrain
Copy link

the collum with the id 438 is the "step time /s" and it a <f8. Here a mpr file where we get the problem and the mpt file associated with the collum

data_gcpl.zip

The problem can be solveby adding the following line to VMPdata_colID_dtype_map :

438: ("step time/s", "<f8"),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants