Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate runtime dependencies and development dependencies in all the plugins gemspec #2078

Open
ph opened this issue Nov 14, 2014 · 2 comments

Comments

@ph
Copy link
Contributor

ph commented Nov 14, 2014

All the dependencies for the plugins are declared as runtime dependencies.
But in reality some of the dependencies are only used to make the test run.

One of the gem with the problem is the ruby filter (https://github.com/logstash-plugins/logstash-filter-ruby)

# Gem dependencies
s.add_runtime_dependency 'logstash', '>= 1.4.0', '< 2.0.0'
s.add_runtime_dependency 'logstash-filter-date'
@suyograo
Copy link
Contributor

@ph is this still an issue

@ph
Copy link
Contributor Author

ph commented Dec 19, 2014

Yes this is still an issue, we will have to go through all the plugins to make the changes. I dont think we can automate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants