Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the app icon of appdata files loaded from local #1070

Open
ryonakano opened this issue Sep 9, 2019 · 2 comments
Open

Show the app icon of appdata files loaded from local #1070

ryonakano opened this issue Sep 9, 2019 · 2 comments
Labels
Priority: Wishlist Not a bug. A new feature or enhancement

Comments

@ryonakano
Copy link
Member

Screenshot from 2019-09-10 07-47-58

We can load and show the local appdata file with the --load-local option, but the app icon is not loaded and the application-default-icon is used instead.
I guess it would be useful e.g. when we redesign an app icon and want to check how it looks like in the AppCenter (like the contrast between the icon and the background color of the banner) if we can also specify and load a local app icon.

@cassidyjames cassidyjames added the Priority: Wishlist Not a bug. A new feature or enhancement label Sep 9, 2019
@davidmhewitt
Copy link
Member

There are multiple things about this that are problematic.

  • Firstly, icons are not usually specified in AppData manually, they're usually added at the build stage by appstream-generator so we'd have to think about how to specifiy which icon to load
  • Secondly, when real icons are loaded in AppCenter, they come from a rasterized source (i.e. appstream-generator takes the nice svg you've made and renders it to a png to ship in the repo). We've seen multiple cases of this rendering going a bit wrong so if we loaded an svg here, it wouldn't necessarily be representative of the final result and may give a false impression of the possible fidelity/quality of the final icon.

While I agree it would be a useful feature to have, the technical constraints mean it's semi-difficult to implement and may not give the couple of developers that use the feature a representative result anyway.

@aral
Copy link

aral commented Nov 15, 2021

Workaround: You can preview your app icon with --load-local if you specify its identifier in your appdata.xml.in file in an icon tag with type set to stock.

For example:

<icon type="stock">org.small_tech.comet</icon>

(Just make sure to comment it out when you’re done testing or your Flatpak builds will fail.)

Screenshot of the Comet icon displaying locally in AppCenter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Wishlist Not a bug. A new feature or enhancement
Projects
None yet
Development

No branches or pull requests

4 participants