Highlight today in date picker #426
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meisenzahl
approved these changes
Nov 4, 2020
danirabbit
requested changes
Nov 4, 2020
|
I've proposed styles for Gtk.Calendar here elementary/stylesheet#878 |
|
So this is superseded by elementary/stylesheet#878? |
|
@cassidyjames not completely. The part about marking Today is still relevant, but the styles should be removed |
danirabbit
requested changes
Nov 18, 2020
Comment on lines
+31
to
+33
| To install, use `sudo ninja install` | ||
|
|
||
| ninja install | ||
| sudo ninja install |
There was a problem hiding this comment.
This is intentional since ninja will use polkit. Please revert this
Comment on lines
+58
to
+65
| private const string CSS = """ | ||
| calendar | ||
| { | ||
| background: transparent; | ||
| padding: 3px; | ||
| } | ||
| """; | ||
|
|
There was a problem hiding this comment.
Styles are accounted for in the system stylesheet already, so we shouldn't have them here
Comment on lines
+188
to
+189
| } | ||
| else { |
There was a problem hiding this comment.
elementary code style is cuddled else
Suggested change
| } | |
| else { | |
| } else { |
|
Gonna close this since there's been no response to code review for over a month. Please feel free to reopen if changes are made :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #384 and improves the styling of the date picker a bit.
Before:
After:
