Missing style classes in Granite 7 to port from Gtk3 to Gtk4

[marbetschar]

I started working on the Gtk4 port of Mail and noticed that the following Gtk3 style classes are not available in Granite. Not sure if this is a bug or intentional - in any case, please advise how to migrate them to Gtk4 / Granite 7:

• Gtk.STYLE_CLASS_BACKGROUND
• Gtk.STYLE_CLASS_SIDEBAR
• Gtk.STYLE_CLASS_TOOLBAR
• Gtk.STYLE_CLASS_INLINE_TOOLBAR

[danirabbit]

Oops yeah SIDEBAR and BACKGROUND are definitely an oversight and need to be added

action bars previously using INLINE_TOOLBAR should use FLAT instead

I don’t think the stylesheet has a style for .toolbar and Gtk.Toolbar was removed in Gtk4, so I’d be curious to know how that’s being used so we can figure out how to migrate it

[marbetschar]

Regarding Gtk.STYLE_CLASS_TOOLBAR: Mail is only using it in the AttachmentBar.vala (used to list attachments below a message).

I will test if it makes any visual differences if the class is there - if so, I will hardcode the string value and otherwise simply remove the class alltogether. Would you agree to this course of action? Or do I miss something here?

[marbetschar]

PS: Found another style class which is used in Mail but does not appear in Granite: Gtk.STYLE_CLASS_ENTRY - whats the migration path for this one?

[danirabbit]

@marbetschar ah so for the attachment one, probably either pack that into an actionbar?or set the css name of the flowbox to “actionbar”, whichever one preserves the styles better there. I’m pretty sure the “toolbar” style class is removed completely in the gtk4 stylesheet

I think the entry one is a workaround for not being able to pack children into an entry, but I think that’s changed in Gtk. That’s also used for cssname as well right? So you could manually set the cssname to “entry” for the same effect or see if we can pack those children to the end of the entry and drop all the style magic we’re doing there

[avojak]

Possibly related, should there be a Granite.STYLE_CLASS_TITLEBAR? I noticed that Music uses the string "titlebar" instead of a constant (https://github.com/elementary/music/blob/main/src/MainWindow.vala#L34).

[alainm23]

You could use Granite.Placeholder instead.

[jeremypw]

I suspect it will be removed in the near future.