Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envoy_reloadable_features_dns_nodata_noname_is_success deprecation #38040

Open
publish-envoy bot opened this issue Jan 16, 2025 · 0 comments · May be fixed by #38060
Open

envoy_reloadable_features_dns_nodata_noname_is_success deprecation #38040

publish-envoy bot opened this issue Jan 16, 2025 · 0 comments · May be fixed by #38060
Assignees
@abeyad
Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt

Comments

@publish-envoy
Copy link
Contributor

publish-envoy bot commented Jan 16, 2025

Your change commit e2998e1 (getaddrinfo: Treat EAI_NONAME and EAI_NODATA as non-failures) introduced a runtime guarded feature. It has been 6 months since the new code has been exercised by default, so it's time to remove the old code path. This issue tracks source code cleanup so we don't forget.
@publish-envoy publish-envoy bot added deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt labels Jan 16, 2025
@abeyad abeyad linked a pull request Jan 16, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abeyad abeyad

Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

runtime: Remove dns_nodata_noname_is_success runtime guard abeyad/envoy
1 participant
@abeyad