Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation incorrect for Cluster::upstream_config, and Cluster::typed_extension_protocol_options #38065

Open
ravenblackx opened this issue Jan 16, 2025 · 1 comment

Comments

@ravenblackx
Copy link
Contributor

https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/cluster/v3/cluster.proto#envoy-v3-api-field-config-cluster-v3-cluster-upstream-config shows 7 supported extensions, but actually only supports 4 of them.

https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/cluster/v3/cluster.proto#envoy-v3-api-field-config-cluster-v3-cluster-typed-extension-protocol-options shows no supported extensions, but should be specifying at least envoy.upstreams.http.http_protocol_options, since that's apparently how we use that, at least according to the protobuf file comments:

// typed_extension_protocol_options:
// envoy.extensions.upstreams.http.v3.HttpProtocolOptions:
// "@type": type.googleapis.com/envoy.extensions.upstreams.http.v3.HttpProtocolOptions
// upstream_http_protocol_options:
// auto_sni: true
// common_http_protocol_options:
// idle_timeout: 1s
// explicit_http_config:
// http2_protocol_options:
// max_concurrent_streams: 100
// .... [further cluster config]

This has led to confusion in other issues.

@ravenblackx
Copy link
Contributor Author

@yanavlasov @adisuissa as the config folks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant