EIP-7002 and EIP-7251: withdrawal and consolidation requests #1084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1084 +/- ##
==========================================
+ Coverage 94.29% 94.31% +0.02%
==========================================
Files 159 159
Lines 17160 17221 +61
==========================================
+ Hits 16181 16242 +61
Misses 979 979
Flags with carried forward coverage won't be shown. Click here to find out more.
|
aeb0c13 to
a76c241
Compare
a35aeed to
805d987
Compare
997baa7 to
792d126
Compare
pdobacz
reviewed
Dec 17, 2024
Member
There was a problem hiding this comment.
should we add more tests here for the new function (system_call_block_end)?
gumb0
commented
Dec 17, 2024
chfast
reviewed
Dec 18, 2024
chfast
reviewed
Dec 18, 2024
| GetInputFn* get_input = nullptr; ///< How to get the input for the system call. | ||
| /// Type of requests returned by block end system call. | ||
| /// Ignored for block start system contracts. | ||
| Requests::Type request_type = Requests::Type::deposit; |
Member
There was a problem hiding this comment.
This abstraction is quite weak because we have disjoint set of objects with get_input and requires_type. Fine for me for now though.
chfast
approved these changes
Dec 18, 2024
Member
chfast
left a comment
There was a problem hiding this comment.
Maybe squash commits related to EIP-7251. They are tiny.
test/state/system_contracts.cpp
Outdated
|
|
||
| const Transaction empty_tx{}; | ||
| Host host{rev, vm, state, block, block_hashes, empty_tx}; | ||
| [[maybe_unused]] const auto res = vm.execute(host, rev, msg, code.data(), code.size()); |
Member
There was a problem hiding this comment.
Suggested change
| [[maybe_unused]] const auto res = vm.execute(host, rev, msg, code.data(), code.size()); | |
| const auto res = vm.execute(host, rev, msg, code.data(), code.size()); |
178d4f8 to
c2c75eb
Compare
pdobacz
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eips.ethereum.org/EIPS/eip-7002
https://eips.ethereum.org/EIPS/eip-7251