precompiles: Refactor BN254 ecpairing #1175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the loop preparing inputs for the BN254 pairing check.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1175 +/- ##
==========================================
- Coverage 94.49% 94.48% -0.01%
==========================================
Files 170 170
Lines 18024 18020 -4
==========================================
- Hits 17031 17027 -4
Misses 993 993
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
rodiazet
reviewed
Mar 21, 2025
|
|
||
| static constexpr auto OUTPUT_SIZE = 32; | ||
| static constexpr size_t PAIR_SIZE = 192; | ||
| assert(output_size >= OUTPUT_SIZE); |
Member
There was a problem hiding this comment.
Why not just output_size == OUTPUT_SIZE?
Member
Author
There was a problem hiding this comment.
This is generic precompile's implementation framework, sometimes it passes bigger buffers, but I don't remember why currently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the loop preparing inputs for the BN254 pairing check.