Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] skip_existing not working for flacs #322

Closed
HGGamers opened this issue Jan 9, 2025 · 3 comments · Fixed by #334
Closed

[Bug] skip_existing not working for flacs #322

HGGamers opened this issue Jan 9, 2025 · 3 comments · Fixed by #334
Assignees
Labels
bug Something isn't working

Comments

@HGGamers
Copy link

HGGamers commented Jan 9, 2025

What happened?

Simply have a playlist that has already been downloaded and “skip_existing” activated. Try to download this playlist again. Only songs with the “.m4a” extension will be recognized as already downloaded. I'm not sure how Tidal works, but if you have “extract_flac” disabled, some songs will still be downloaded in “.flac”. So the ones that have already been downloaded as “.flac” will be downloaded again, even if you already have them. If you activate “extract_flac”, every song will be downloaded again and no song will be detected as already downloaded.

Version App

0.24.1

What operating system are you seeing the problem on?

Windows

Relevant log output

> Download skipped, since file exists: 'Y:\Test\Playlists\Future Proof\Kush Jones - Rod Strickland Beat.m4a'
> Download skipped, since file exists: 'Y:\Test\Playlists\Future Proof\Shygirl, Club Shy, Yseult - FMe (feat. Yseult).m4a'
> Download skipped, since file exists: 'Y:\Test\Playlists\Future Proof\Taiki Nulight, Hamdi - Patterns.m4a'
> Download skipped, since file exists: 'Y:\Test\Playlists\Future Proof\Megra - Look Into My Eyes.m4a'
> Download skipped, since file exists: 'Y:\Test\Playlists\Future Proof\Daniel Avery - I Miss You (EC1 Edit).m4a'
> Download skipped, since file exists: 'Y:\Test\Playlists\Future Proof\Bubble Love, Ross from Friends, Jeshi, Cameo Blush - Close Your Eyes.m4a'
> Download skipped, since file exists: 'Y:\Test\Playlists\Future Proof\TOKiMONSTA, Kaelin Ellis - For You.m4a'
Could not retrieve lyrics for `96 Back - 96 Kisses`.
> Downloaded item '96 Back - 96 Kisses'.
> Next download will start in 3.6 seconds.
Could not retrieve lyrics for `Blawan - BouQ`.
> Downloaded item 'Blawan - BouQ'.
> Next download will start in 4.3 seconds.
Could not retrieve lyrics for `Two Shell - Magic Powers`.
> Downloaded item 'Two Shell - Magic Powers'.
> Next download will start in 4.3 seconds.
Could not retrieve lyrics for `Dj Manny - Only U`.
> Downloaded item 'Dj Manny - Only U'.

Your settings

{
    "skip_existing": true,
    "lyrics_embed": true,
    "lyrics_file": false,
    "video_download": false,
    "download_delay": true,
    "download_base_path": "Y:\\Test",
    "quality_audio": "HI_RES_LOSSLESS",
    "quality_video": "1080",
    "format_album": "Albums/{album_artist} - {album_title}{album_explicit}/{album_track_num}. {artist_name} - {track_title}",
    "format_playlist": "Playlists/{playlist_name}/{artist_name} - {track_title}",
    "format_mix": "Mix/{mix_name}/{artist_name} - {track_title}",
    "format_track": "Tracks/{artist_name} - {track_title}{track_explicit}",
    "format_video": "Videos/{artist_name} - {track_title}{track_explicit}",
    "video_convert_mp4": false,
    "path_binary_ffmpeg": "C:\\Program Files\\ffmpeg\\bin\\ffmpeg.exe",
    "metadata_cover_dimension": "1280",
    "metadata_cover_embed": true,
    "cover_album_file": true,
    "extract_flac": false,
    "downloads_simultaneous_per_track_max": 20,
    "download_delay_sec_min": 3.0,
    "download_delay_sec_max": 5.0,
    "album_track_num_pad_min": 1,
    "downloads_concurrent_max": 3,
    "symlink_to_track": false,
    "playlist_create": true
}
@HGGamers HGGamers added the bug Something isn't working label Jan 9, 2025
@exislow exislow reopened this Jan 11, 2025
@exislow
Copy link
Owner

exislow commented Jan 11, 2025

Please do not ignore all the direction provided here on how to create an issue.

-> Provide all details to re-produce your issue. This includes in this case a link to a minimal playlist where this happens.

@exislow exislow added the question Further information is requested label Jan 11, 2025
@HGGamers
Copy link
Author

HGGamers commented Jan 11, 2025

I didn't ignore this as it's irelrevant what playlist it is.
All the playlists I tested were the same. But here is a small playlist:
Link

@exislow
Copy link
Owner

exislow commented Jan 12, 2025

Thank you for providing the playlist.

P.S.: If it would be irrelevant I wouldn't have asked for it. If this issue would be trivial you could fix it yourself, couldn't you? The TIDAL backend behaves different for each track. Try to debug it yourself, since this app is open source, if you do not believe me.

@exislow exislow removed the question Further information is requested label Jan 12, 2025
@exislow exislow linked a pull request Jan 12, 2025 that will close this issue
exislow added a commit that referenced this issue Jan 12, 2025
…g-for-flacs

👷 File extension guesser improved. Fixes #322
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants