feat(interface): php_impl_interface macro by kakserpom · Pull Request #621 · extphprs/ext-php-rs

kakserpom · 2025-12-20T06:50:08Z

Implements #590 and #308

coveralls · 2025-12-20T06:53:48Z

Pull Request Test Coverage Report for Build 21479162825

Details

16 of 130 (12.31%) changed or added relevant lines in 8 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.5%) to 34.529%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/internal/class.rs	0	2	0.0%
src/builders/class.rs	3	7	42.86%
src/class.rs	0	4	0.0%
src/builders/module.rs	1	6	16.67%
crates/macros/src/lib.rs	0	11	0.0%
crates/macros/src/interface.rs	5	17	29.41%
crates/macros/src/function.rs	7	26	26.92%
crates/macros/src/impl_interface.rs	0	57	0.0%

Files with Coverage Reduction	New Missed Lines	%
src/builders/class.rs	1	57.82%

Totals
Change from base Build 21478368156:	-0.5%
Covered Lines:	1916
Relevant Lines:	5549

💛 - Coveralls

crates/macros/src/class.rs

kakserpom · 2026-01-13T05:38:27Z

@ptondereau @Xenira

Please review/merge.

kakserpom · 2026-01-25T09:48:13Z

@ptondereau Rebased and green. This one next?

ptondereau

Nice first draft.

But let me add some suggestions:

Can we add a compile-time error if #[php_impl_interface] is used on a non-trait impl?
Maybe throw a warning if trait methods aren't also in #[php_impl]
We should add an example in the documentation showing cross-crate interface implementation

crates/macros/src/impl_interface.rs

tests/src/integration/interface/mod.rs

crates/macros/src/interface.rs

ptondereau

I'll do a final review tomorrow but for now LGTM

ptondereau

One more things 😅

crates/macros/src/impl_interface.rs

crates/macros/src/function.rs

crates/macros/tests/expand/class.expanded.rs

crates/macros/src/impl_interface.rs

kakserpom · 2026-01-26T15:38:14Z

One more things 😅

All done, Mr Colombo, but CI is acting weird

ptondereau · 2026-01-26T15:55:30Z

One more things 😅

All done, Mr Colombo, but CI is acting weird

thank you!
it seems that GH is having some trouble... Let's wait, and I will merge once feedback from CI is green

ptondereau · 2026-01-27T10:48:51Z

@kakserpom Maybe you might be interested in this #653

kakserpom · 2026-01-27T10:52:19Z

@kakserpom Maybe you might be interested in this #653

How is it related?

kakserpom · 2026-01-28T14:13:51Z

@ptondereau

ptondereau

LGTM, nitpicks again

crates/macros/src/impl_interface.rs

ptondereau · 2026-01-29T13:00:54Z

also 1 rebase and i'll merge ;)

kakserpom mentioned this pull request Dec 20, 2025

declaring interfaces using traits #172

Closed

kakserpom force-pushed the 590_interfaces branch 8 times, most recently from e5c61bb to 7febcb0 Compare December 21, 2025 20:22

ptondereau reviewed Dec 23, 2025

View reviewed changes

crates/macros/src/class.rs Outdated Show resolved Hide resolved

kakserpom force-pushed the 590_interfaces branch 5 times, most recently from f47b1a1 to 174c959 Compare December 24, 2025 05:31

This comment was marked as outdated.

Sign in to view

kakserpom force-pushed the 590_interfaces branch 2 times, most recently from 4cb1cc0 to 240b4fb Compare December 24, 2025 08:25

kakserpom requested a review from ptondereau January 3, 2026 13:33

kakserpom force-pushed the 590_interfaces branch from 240b4fb to ce32533 Compare January 13, 2026 05:36

kakserpom force-pushed the 590_interfaces branch 4 times, most recently from 3d0cdd2 to 1a82750 Compare January 25, 2026 08:29

ptondereau requested changes Jan 25, 2026

View reviewed changes

crates/macros/src/impl_interface.rs Outdated Show resolved Hide resolved

tests/src/integration/interface/mod.rs Show resolved Hide resolved

crates/macros/src/interface.rs Outdated Show resolved Hide resolved

kakserpom force-pushed the 590_interfaces branch 2 times, most recently from 7cb7add to d3c2b8c Compare January 25, 2026 14:04

ptondereau previously approved these changes Jan 25, 2026

View reviewed changes

kakserpom requested a review from ptondereau January 26, 2026 11:28

ptondereau reviewed Jan 26, 2026

View reviewed changes

crates/macros/src/impl_interface.rs Outdated Show resolved Hide resolved

crates/macros/src/function.rs Show resolved Hide resolved

crates/macros/tests/expand/class.expanded.rs Show resolved Hide resolved

crates/macros/src/impl_interface.rs Show resolved Hide resolved

kakserpom dismissed ptondereau’s stale review via c8d4301 January 26, 2026 14:35

kakserpom force-pushed the 590_interfaces branch 7 times, most recently from f9e0e55 to f733620 Compare January 26, 2026 15:16

kakserpom force-pushed the 590_interfaces branch 2 times, most recently from 98e4300 to 9d51536 Compare January 27, 2026 03:02

kakserpom requested a review from ptondereau January 27, 2026 03:20

kakserpom force-pushed the 590_interfaces branch from 9d51536 to e96b63a Compare January 28, 2026 13:41

ptondereau previously approved these changes Jan 29, 2026

View reviewed changes

crates/macros/src/impl_interface.rs Outdated Show resolved Hide resolved

crates/macros/src/impl_interface.rs Outdated Show resolved Hide resolved

kakserpom dismissed ptondereau’s stale review via 5b6264d January 29, 2026 12:46

kakserpom force-pushed the 590_interfaces branch from e96b63a to 5b6264d Compare January 29, 2026 12:46

feat(interface): php_impl_interface macro extphprs#590

030347b

kakserpom force-pushed the 590_interfaces branch from 5b6264d to 030347b Compare January 29, 2026 13:02

kakserpom requested a review from ptondereau January 29, 2026 13:30

ptondereau merged commit a4a2814 into extphprs:master Jan 29, 2026
65 checks passed

Xenira mentioned this pull request Jan 29, 2026

chore: release #661

Merged

kakserpom added a commit to kakserpom/ext-php-rs that referenced this pull request Feb 5, 2026

feat(interface): php_impl_interface macro extphprs#590 (extphprs#621)

4c516a1

Uh oh!

Conversation

kakserpom commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 21479162825

Details

💛 - Coveralls

Uh oh!

Uh oh!

This comment was marked as outdated.

kakserpom commented Jan 13, 2026

Uh oh!

kakserpom commented Jan 25, 2026

Uh oh!

ptondereau left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ptondereau left a comment

Choose a reason for hiding this comment

Uh oh!

ptondereau left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kakserpom commented Jan 26, 2026

Uh oh!

ptondereau commented Jan 26, 2026

Uh oh!

ptondereau commented Jan 27, 2026

Uh oh!

kakserpom commented Jan 27, 2026

Uh oh!

kakserpom commented Jan 28, 2026

Uh oh!

ptondereau left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ptondereau commented Jan 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kakserpom commented Dec 20, 2025 •

edited

Loading

coveralls commented Dec 20, 2025 •

edited

Loading