Skip to content

[Fizz] Detatch boundary after flushing segment with boundary - #34694

Merged
gnoff merged 1 commit into
react:mainfrom
gnoff:detatch-boundary-after-flush
Oct 2, 2025
Merged

gnoff merged 1 commit into
react:mainfrom
gnoff:detatch-boundary-after-flush

Conversation

@gnoff

@gnoff gnoff commented Oct 2, 2025 •

Copy link
Copy Markdown
Collaborator

When we flush a Suspense boundary we might not flush the fallback segment, it might only flush a placeholder instead. In this case the segment can flush again but we do not want to flush the boundary itself a second time. We now detach the boundary after flushing it.

better solution to: #34668

@meta-cla meta-cla Bot added the CLA Signed label Oct 2, 2025
@gnoff
gnoff requested a review from sebmarkbage October 2, 2025 19:21
@github-actions github-actions Bot added the React Core Team Opened by a member of the React Core Team label Oct 2, 2025
@gnoff
gnoff force-pushed the detatch-boundary-after-flush branch from 66754f3 to 693513a Compare October 2, 2025 19:23
When we flush a Suspense boundary we might not flush the fallbak segment, it might only flush a placeholder instead. In this case the segment can flush again but we do not want to flush the boundary itself a second time. We now detatch the boundary after flushing it.
@gnoff
gnoff force-pushed the detatch-boundary-after-flush branch from 693513a to 2eeb068 Compare October 2, 2025 19:24
@react-sizebot

Copy link
Copy Markdown

Comparing: c825f03...2eeb068

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 536.14 kB 536.14 kB = 94.81 kB 94.81 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 663.96 kB 663.96 kB = 117.04 kB 117.04 kB
facebook-www/ReactDOM-prod.classic.js = 687.83 kB 687.83 kB = 121.08 kB 121.08 kB
facebook-www/ReactDOM-prod.modern.js = 678.26 kB 678.26 kB = 119.43 kB 119.43 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 2eeb068

@gnoff
gnoff merged commit 7d9f876 into react:main Oct 2, 2025
1 of 2 checks passed
@gnoff
gnoff deleted the detatch-boundary-after-flush branch October 2, 2025 20:22
github-actions Bot pushed a commit that referenced this pull request Oct 2, 2025
When we flush a Suspense boundary we might not flush the fallback
segment, it might only flush a placeholder instead. In this case the
segment can flush again but we do not want to flush the boundary itself
a second time. We now detach the boundary after flushing it.

better solution to: #34668

DiffTrain build for [7d9f876](7d9f876)
buidangphuc added a commit to buidangphuc/agora that referenced this pull request Nov 5, 2026
…ush bug

E2e scenario "The page streams to the end whatever the description length"
(40 listings, descriptions of 1-40 chars, each PDP must end in </html> and
include #qa) and a vitest of the upstream React regression case
(react/react#34694) on Next's vendored react-dom/server. OpenSpec change
pdp-stream-cutoff. Red on Next 15.5.28's vendored React (7-18 char
descriptions cut at ~121 KB; the vitest reports the invariant).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
buidangphuc added a commit to buidangphuc/agora that referenced this pull request Nov 5, 2026
…r cuts off

The buyer PDP stopped streaming for some page sizes: the React server
renderer vendored by Next 15.5.28 flushed the AI review summary boundary
twice when its fallback segment was still suspended and threw "A previously
unvisited boundary must have exactly one root segment"
(react/react#34668). scripts/patch-react-dom-boundary.mjs backports the
upstream one-line fix (react/react#34694) into every vendored Fizz bundle
during dev and build, and exits 1 when Next changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants