Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

local and retract to route based on Manifold or ManifoldGaussian #159

Open
mhmukadam opened this issue Apr 13, 2022 · 0 comments
Open

local and retract to route based on Manifold or ManifoldGaussian #159

mhmukadam opened this issue Apr 13, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers refactor Refactor library components

Comments

@mhmukadam
Copy link
Contributor

Maybe in a later PR we could rename the old local and retract to something like _local_lie_group, and these ones to something like _local_gaussian. Then in Theseus' __init__.py we define local to route to the appropriate one based on the type.

Originally posted by @luisenp in #121 (comment)
@mhmukadam mhmukadam added enhancement New feature or request refactor Refactor library components labels Apr 13, 2022
@mhmukadam mhmukadam mentioned this issue Apr 13, 2022
Merged
11 tasks
@mhmukadam mhmukadam added the good first issue Good for newcomers label Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers refactor Refactor library components
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mhmukadam