Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastify 2.0 support #66

Closed
karlos1337 opened this issue Feb 26, 2019 · 2 comments
Closed

Fastify 2.0 support #66

karlos1337 opened this issue Feb 26, 2019 · 2 comments

Comments

@karlos1337
Copy link

Can't build my app since Fastify 2 upgrade, fastify-plugin breaks with:

Error: fastify-plugin - expected '^1.0.0' fastify version, '2.0.0' is installed

On removing that check from fastify-plugin source (~ line 65) all works fine again, not a suggestion, for sure will exists a better fix than that 😅 , but seems that this check is the only problem.

@mcollina
Copy link
Member

One of the plugins you are using requires fastify v1. If you look at the stacktrace you'll see which one.

@karlos1337
Copy link
Author

You're right, related with fastify/fastify-cors#17 , sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants