Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use semver coerce #88

Merged
merged 1 commit into from
May 17, 2020
Merged

Use semver coerce #88

merged 1 commit into from
May 17, 2020

Conversation

joobisb
Copy link
Contributor

@joobisb joobisb commented May 17, 2020

This PR resolves #87

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

@joobisb joobisb mentioned this pull request May 17, 2020
Closed
delvedor
delvedor approved these changes May 17, 2020
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

How can we test this?

@mcollina
Copy link
Member

This is already tested from my point of view.

mcollina
mcollina approved these changes May 17, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit ae1592e into fastify:master May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delvedor delvedor delvedor approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

semver.coerce?
3 participants
@joobisb @mcollina @delvedor