Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix plugin metadata interface [TypeScript] #92

Merged
merged 2 commits into from
Jul 24, 2020
Merged

Fix plugin metadata interface [TypeScript] #92

merged 2 commits into from
Jul 24, 2020

Conversation

vinicius0026
Copy link
Contributor

Fixes #91

I've taken the liberty to rename PluginOptions to PluginMetadata and I'm exporting PluginOptions for backward compatibility. If sticking to PluginOptions is preferred, let me know and I'll revert this change.

I don't see any docs that need update, but let me know if I missed something.

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

@jsumners jsumners changed the title Fix plugin metadata interface Fix plugin metadata interface [TypeScript] Jul 22, 2020
mcollina
mcollina approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina requested a review from Ethan-Arrowood July 22, 2020 15:38
@mcollina mcollina merged commit 875a8e3 into fastify:master Jul 24, 2020
@vinicius0026 vinicius0026 deleted the fix-plugin-metadata-interface branch July 24, 2020 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error creating a new TypeScript plugin using fastify-plugin
3 participants
@vinicius0026 @mcollina @Ethan-Arrowood