-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ParseSelector return unknown in its return type instead of always using the fallback type when using TS 5.4 #36
Comments
You can try |
The case where this happens is not when having a known selector in ParseSelector but when defining a generic function (i.e. the same case than |
i.e. a case where we don't know whether we will have to use the fallback or a parsed type, but having both branches of the union. |
|
It worked, thank you! |
See fregante/delegate-it#50 (and fregante/delegate-it#51 which runs the testsuite with typescript 5.4).
See also ed964d1#r139690533 where the discussion started.
To me, the change in the
querySelectorAll
type in that commit should not exist. It is a workaround for the fact thatParseSelector
now returnsunknown
while it should never do it.My intuition is that
ExpandAnd
is the one not properly handling the fallback.The text was updated successfully, but these errors were encountered: