Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

怎么设置允许http访问呢,我们是内网做的,不需要https的 #8

Open
loverto opened this issue May 26, 2017 · 7 comments

Comments

@loverto
Copy link

loverto commented May 26, 2017

怎么设置允许http访问呢,我们是内网做的,不需要https的,

@gabrie-allaigre
Copy link
Owner

Sorry, I don't understand. Please write english.
With google translation, SonarQube requires to have https for oauth

@loverto
Copy link
Author

loverto commented May 26, 2017

Our system is used by the internal network, I think there is no need to use https, this plugin must use https? Or that is sonarqube need, if I do not want to use https, then I manually modify the plugin can solve this problem, I would like to know where to amend?

@loverto
Copy link
Author

loverto commented May 26, 2017

2017.05.26 09:20:02 ERROR web[AVxECceHChrxi02dAADk][o.s.s.a.AuthenticationError] Fail to initialize authentication with provider 'gitlab'

@misterfifi1
Copy link

Hi,
In this case, Gitlab is an OAuth provider and follow the OAUTH 2.0 RFC, the communication between servers must be secured. so HTTPS is mandatory. I don't know if it is possible to use it in your context, but you can use https://letsencrypt.org/ to create the certificate.
Regards,

@Totti0135
Copy link

Totti0135 commented Jul 11, 2017

I have the same question, but I just want to know wether both sonarqube and gitlab need https or just sonarqube?

@gabrie-allaigre
Copy link
Owner

Hi,
SonarQube need https.
GitLab maybe.

@misterfifi1
Copy link

misterfifi1 commented Jul 19, 2017

Hi,
From my point of view, following the OAuth 2.0 RFC (Section: 10.9. Ensuring Endpoint Authenticity), all servers must be secured and the communication should be done through TLS (only localhost is autorised in HTTP for tests purpose). Therefore HTTPS should be activated on both.

if needed, you can create a free certificate using https://letsencrypt.org/

Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants