fix(spanner): remove json-iterator dependency#10099
Merged
rahul2393 merged 3 commits intogoogleapis:mainfrom May 3, 2024
Merged
fix(spanner): remove json-iterator dependency#10099rahul2393 merged 3 commits intogoogleapis:mainfrom
rahul2393 merged 3 commits intogoogleapis:mainfrom
Conversation
json-iterator heavily relies on an unmaintained modern-go/reflect2 that pokes at the internals of Go runtime. This was shown to cause failures in golang/go#54766 (comment). Switching to encoding/json does come with a performance penalty. Updates googleapis#9380
rahul2393
approved these changes
May 3, 2024
Contributor
|
@rahul2393 you'll need to squash/merge this yourself or add the automerge label |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
json-iterator heavily relies on an unmaintained modern-go/reflect2
that pokes at the internals of Go runtime. This was shown to cause
failures in golang/go#54766 (comment).
Switching to encoding/json does come with a performance penalty.
Updates #9380