Skip to content

feat(spanner/spansql): Add support for DROP SEARCH INDEX and ALTER SEARCH INDEX#11961

Merged
rahul2393 merged 4 commits intogoogleapis:mainfrom
rasviitanen:rasviitanen/alter-search
Apr 25, 2025
Merged

feat(spanner/spansql): Add support for DROP SEARCH INDEX and ALTER SEARCH INDEX#11961
rahul2393 merged 4 commits intogoogleapis:mainfrom
rasviitanen:rasviitanen/alter-search

Conversation

@rasviitanen
Copy link
Contributor

@rasviitanen rasviitanen commented Apr 8, 2025

Adds support for DROP SEARCH INDEX and ALTER SEARCH INDEX.
Follow up for #11522

@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Apr 8, 2025
@rasviitanen rasviitanen marked this pull request as ready for review April 8, 2025 10:56
@rasviitanen rasviitanen requested a review from a team as a code owner April 8, 2025 10:56
@rasviitanen rasviitanen requested a review from a team April 8, 2025 10:56
@rasviitanen
Copy link
Contributor Author

@rahul2393 Maybe you would be able to review and run kokoro? No stress though, just want to make sure this doesn't fall between the cracks. Thank you!

@rasviitanen
Copy link
Contributor Author

Would you be able to have a look on this @olavloite?
Would be nice to get it released so that search indexes can be used by schema management tools like golang-migrate/migrate and hammer. Thanks 🙏

@apstndb
Copy link
Contributor

apstndb commented Apr 24, 2025

Would be nice to get it released so that search indexes can be used by schema management tools like golang-migrate/migrate and hammer. Thanks 🙏

FYI: hammer is already migrated to another Spanner GoogleSQL parser implementation, memefish.
daichirata/hammer#66

@rasviitanen
Copy link
Contributor Author

haha I looked last week and then it was stale.
Thanks for the info, that looks great 🎉

@rahul2393 rahul2393 enabled auto-merge (squash) April 24, 2025 13:43
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2025
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 25, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 25, 2025
@rahul2393 rahul2393 merged commit 952cd7f into googleapis:main Apr 25, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants