feat(spanner/spansql): Add support for DROP SEARCH INDEX and ALTER SEARCH INDEX#11961
Merged
rahul2393 merged 4 commits intogoogleapis:mainfrom Apr 25, 2025
Merged
Conversation
Contributor
Author
|
@rahul2393 Maybe you would be able to review and run kokoro? No stress though, just want to make sure this doesn't fall between the cracks. Thank you! |
Contributor
Author
|
Would you be able to have a look on this @olavloite? |
Contributor
FYI: hammer is already migrated to another Spanner GoogleSQL parser implementation, memefish. |
Contributor
Author
|
haha I looked last week and then it was stale. |
rahul2393
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for
DROP SEARCH INDEXandALTER SEARCH INDEX.Follow up for #11522