feat(spanner): add support of AFE and GRPC metrics in client-side metrics#12067
Merged
feat(spanner): add support of AFE and GRPC metrics in client-side metrics#12067
Conversation
908acc1 to
21036a9
Compare
HailongWen
reviewed
May 6, 2025
HailongWen
reviewed
May 6, 2025
HailongWen
reviewed
May 6, 2025
HailongWen
reviewed
May 6, 2025
44b311b to
eb2e763
Compare
olavloite
approved these changes
May 7, 2025
Contributor
olavloite
left a comment
There was a problem hiding this comment.
Is there any way that we could add some more tests for this? E.g. would it be possible to have the mock server return these headers, and then verify that these are correctly being collected by the client?
HailongWen
reviewed
May 7, 2025
| var ( | ||
| validDBPattern = regexp.MustCompile("^projects/(?P<project>[^/]+)/instances/(?P<instance>[^/]+)/databases/(?P<database>[^/]+)$") | ||
| validDBPattern = regexp.MustCompile("^projects/(?P<project>[^/]+)/instances/(?P<instance>[^/]+)/databases/(?P<database>[^/]+)$") | ||
| serverTimingPattern = regexp.MustCompile(`([a-zA-Z0-9_-]+);\s*dur=(\d*\.?\d+)`) |
Contributor
There was a problem hiding this comment.
nit: seems that ".5" will also match in this regex. That is probably fine.
Contributor
Author
|
@olavloite I have updated the unit test to validate the gfe header from mock Session Create/StreamingRead is captured and should be equal to set value for success response and for failed attempt gfe_error_count is exported. |
57986f5 to
d9cbc4b
Compare
rahul2393
commented
May 8, 2025
| t.Fatalf("could not add result: %v", err) | ||
| } | ||
| iter := client.Single().Read(context.Background(), "Users", spanner.AllKeys(), []string{"email"}) | ||
| iter := client.Single().Query(ctx, spanner.NewStatement("SELECT email FROM Users")) |
Contributor
Author
There was a problem hiding this comment.
this is done because StreamingRead mock result not sets the gfe latency header, and in this test we assert/expect missing gfe header count for streaming query
2FaceS-bit
pushed a commit
to 2FaceS-bit/google-cloud-go
that referenced
this pull request
May 12, 2025
…rics (googleapis#12067) * feat(spanner): add support of AFE and GRPC metrics in client-side metrics * incorporate suggestions * added unit test for GFE latencies/error_count and refactored metric collection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds GFE/AFE/GRPC Metrics available for Spanner Engineers.
GRPC metrics are disabled as default currently. To enable set
SPANNER_DISABLE_DIRECT_ACCESS_GRPC_BUILTIN_METRICS=falseAFE metrics will be enabled by default if direct path is used
GOOGLE_SPANNER_ENABLE_DIRECT_ACCESS =true