Skip to content

feat(spanner): BatchWrite#8652

Merged
harshachinta merged 10 commits intogoogleapis:mainfrom
sunny1612:feat-batch-write
Oct 27, 2023
Merged

feat(spanner): BatchWrite#8652
harshachinta merged 10 commits intogoogleapis:mainfrom
sunny1612:feat-batch-write

Conversation

@ghost
Copy link

@ghost ghost commented Oct 5, 2023

Implementation for BatchWrite API.

@ghost ghost self-requested a review as a code owner October 5, 2023 18:59
@ghost ghost self-requested a review October 5, 2023 18:59
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the Spanner API. labels Oct 5, 2023
@harshachinta harshachinta self-requested a review October 12, 2023 09:59
@ghost
Copy link
Author

ghost commented Oct 17, 2023

@harshachinta - Can you please review?

@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 17, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 17, 2023
Co-authored-by: Sri Harsha CH <[email protected]>
@ghost ghost requested a review from harshachinta October 20, 2023 06:59
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2023
Copy link
Contributor

@harshachinta harshachinta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@harshachinta harshachinta added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 26, 2023
@harshachinta harshachinta removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 27, 2023
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 27, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 27, 2023
@harshachinta harshachinta merged commit 507d232 into googleapis:main Oct 27, 2023
@ghost ghost deleted the feat-batch-write branch October 27, 2023 10:36
bhshkh pushed a commit that referenced this pull request Nov 3, 2023
* feat(spanner): BatchWrite

* vet: apply recommendations

* Update comment

Co-authored-by: Sri Harsha CH <[email protected]>

* Add BatchWriteOptions

* remove redundant int conversion

---------

Co-authored-by: Sri Harsha CH <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants