feat(spanner): Add lastUseTime property to session #8942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olavloite
reviewed
Oct 31, 2023
olavloite
approved these changes
Nov 2, 2023
Contributor
olavloite
left a comment
There was a problem hiding this comment.
Approving this as it does what it should, but take a look at my to slightly generic comments and consider whether it is something that we want to pick up, either in this PR or in a follow-up PR.
bhshkh
pushed a commit
that referenced
this pull request
Nov 3, 2023
* feat(spanner): add new field and add relevant tests * feat(spanner): add test for read only transaction * feat(spanner): update lastUseTime before invoking the RPC * feat(spanner): reduce time to ms range in unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8943
For cleaning long running transactions, we would need a track of
lastUseTime, which must be updated for every RPC made with in a transaction. This PR makes necessary code changes for achieving it.