Skip to content

Conversation

@SandeepTuniki
Copy link
Contributor

@SandeepTuniki SandeepTuniki commented Sep 8, 2022

Fixes: http://b/232351537 (internal)

This PR implements support for non-idempotent retry operations for Storage. It sets the default value of retries to 0, but gives the user option to override it.

Implements the retry option for the following operations:

  • storage.hmacKey.create
  • storage.notifications.insert
  • storage.bucket_acl.insert
  • storage.bucket_acl.delete
  • storage.default_object_acl.delete
  • storage.default_object_acl.insert
  • storage.object_acl.delete
  • storage.object_acl.insert

@SandeepTuniki SandeepTuniki requested review from a team as code owners September 8, 2022 09:08
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Sep 8, 2022
@SandeepTuniki SandeepTuniki changed the title feat(storage): add support for non-idempotent operations feat(storage): add retry support for non-idempotent operations Sep 8, 2022
Copy link
Contributor

@bajajneha27 bajajneha27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM
Please also implement storage.default_object_acl.delete , storage.default_object_acl.insert , storage.object_acl.delete , storage.object_acl.insert also

@SandeepTuniki
Copy link
Contributor Author

Please also implement storage.default_object_acl.delete , storage.default_object_acl.insert , storage.object_acl.delete , storage.object_acl.insert also

@bajajneha27 I added the retry options for these methods too.

@SandeepTuniki SandeepTuniki merged commit 7f5b321 into main Sep 14, 2022
@SandeepTuniki SandeepTuniki deleted the storage-non-idempotent-retries branch September 14, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants