feat: Add userClose flag back to StreamWriter #1973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaoleMeng
approved these changes
Feb 3, 2023
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Feb 6, 2023
🤖 I have created a release *beep* *boop* --- ## [2.30.0](https://togithub.com/googleapis/java-bigquerystorage/compare/v2.29.0...v2.30.0) (2023-02-06) ### Features * Add userClose flag back to StreamWriter ([#1973](https://togithub.com/googleapis/java-bigquerystorage/issues/1973)) ([4b51acd](https://togithub.com/googleapis/java-bigquerystorage/commit/4b51acd49292d99e1c3cd670bec695b8bcd3b5c4)) ### Bug Fixes * Close stream connection before each retry ([#1975](https://togithub.com/googleapis/java-bigquerystorage/issues/1975)) ([54e9bb9](https://togithub.com/googleapis/java-bigquerystorage/commit/54e9bb9116eb9781b6f2266f98de4d3853a469b8)) * Improve ConnectionWorker fine logging ([#1972](https://togithub.com/googleapis/java-bigquerystorage/issues/1972)) ([812bcf1](https://togithub.com/googleapis/java-bigquerystorage/commit/812bcf16efdc7a1797435f0b87430c35f27f7245)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if StreamWriter is closed, in multiplexing mode, there is nothing to guard against append to happen again.
We still need StreamWriter has a closed state and we also need to tie it to all the StreamWriter's inflight request queue. I think we need to move back some of the "contractural" StreamWriter test case instead of moving them all down to ConnectionWorker.