feat: add logical termination for RunQueryResponse#956
Merged
cherylEnkidu merged 6 commits intomainfrom May 26, 2022
Merged
Conversation
eb7d4e8 to
fbba090
Compare
fbba090 to
695b504
Compare
wu-hui
reviewed
May 5, 2022
Contributor
wu-hui
left a comment
There was a problem hiding this comment.
Requesting some minor changes.
google-cloud-firestore/src/main/java/com/google/cloud/firestore/Query.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/Query.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/test/java/com/google/cloud/firestore/QueryTest.java
Show resolved
Hide resolved
wu-hui
reviewed
May 9, 2022
Contributor
wu-hui
left a comment
There was a problem hiding this comment.
We are almost done here..
google-cloud-firestore/src/test/java/com/google/cloud/firestore/QueryTest.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/test/java/com/google/cloud/firestore/QueryTest.java
Show resolved
Hide resolved
google-cloud-firestore/src/test/java/com/google/cloud/firestore/QueryTest.java
Show resolved
Hide resolved
wu-hui
reviewed
May 17, 2022
google-cloud-firestore/src/test/java/com/google/cloud/firestore/QueryTest.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@wu-hui |
Contributor
I think this is fine. |
wu-hui
approved these changes
May 24, 2022
|
|
||
| semaphore.acquire(); | ||
|
|
||
| Thread.sleep(200); |
Contributor
There was a problem hiding this comment.
Add comment to explain why we are doing this
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jul 2, 2022
🤖 I have created a release *beep* *boop* --- ## [3.3.0](v3.2.0...v3.3.0) (2022-07-01) ### Features * add logical termination for RunQueryResponse ([#956](#956)) ([1d869c8](1d869c8)) ### Bug Fixes * add build script for JDK 17 native image testing ([#965](#965)) ([963e384](963e384)) ### Performance Improvements * Change how proto was called in Query.java ([#970](#970)) ([f6f6352](f6f6352)) ### Dependencies * update beam.version to v2.40.0 ([#978](#978)) ([44276f8](44276f8)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([#974](#974)) ([6def73d](6def73d)) * update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.12 ([#973](#973)) ([bfb4ec9](bfb4ec9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
cherylEnkidu
pushed a commit
that referenced
this pull request
Dec 11, 2023
🤖 I have created a release *beep* *boop* --- ## [3.3.0](v3.2.0...v3.3.0) (2022-07-01) ### Features * add logical termination for RunQueryResponse ([#956](#956)) ([1d869c8](1d869c8)) ### Bug Fixes * add build script for JDK 17 native image testing ([#965](#965)) ([963e384](963e384)) ### Performance Improvements * Change how proto was called in Query.java ([#970](#970)) ([f6f6352](f6f6352)) ### Dependencies * update beam.version to v2.40.0 ([#978](#978)) ([44276f8](44276f8)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([#974](#974)) ([6def73d](6def73d)) * update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.12 ([#973](#973)) ([bfb4ec9](bfb4ec9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add logical termination for RunQueryResponse.
When the SDK side receives either halfClose or RunQueryResponse.done set to true, the SDK will return user requested documents.