fix: return non-empty metadata for DataBoost queries#3936
Merged
Conversation
Queries that use the PartitionedQuery API in combination with DataBoost can return completely empty result sets (no results and no metadata) for some partitions. The MergedResultSet should ignore these result sets and not use them as the source of metadata for the merged result.
sakthivelmanii
approved these changes
Jul 1, 2025
svc-squareup-copybara
pushed a commit
to cashapp/misk
that referenced
this pull request
Jul 11, 2025
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.96.1` -> `6.97.0` | --- ### Release Notes <details> <summary>googleapis/java-spanner (com.google.cloud:google-cloud-spanner)</summary> ### [`v6.97.0`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6970-2025-07-10) ##### Features - Next release from main branch is 6.97.0 ([#​3984](googleapis/java-spanner#3984)) ([5651f61](googleapis/java-spanner@5651f61)) ##### Bug Fixes - Drop max message size ([#​3987](googleapis/java-spanner#3987)) ([3eee899](googleapis/java-spanner@3eee899)) - Return non-empty metadata for DataBoost queries ([#​3936](googleapis/java-spanner#3936)) ([79c0684](googleapis/java-spanner@79c0684)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 3785bc4fbcfc772b23d1b768da27532aece1a1d9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Queries that use the PartitionedQuery API in combination with DataBoost can return completely empty result sets (no results and no metadata) for some partitions. The MergedResultSet should ignore these result sets and not use them as the source of metadata for the merged result.