fix: update BaseStorageReadChannel to be left open unless explicitly closed #1853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…closed Add two new tests to verify new expected close behavior surfaced from java-storage-nio.
frankyn
approved these changes
Jan 13, 2023
Collaborator
Author
|
The issue this PR addresses was originally discovered in googleapis/java-storage-nio#1084 when updating to v2.17.0. |
9613bdf to
c55a355
Compare
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jan 13, 2023
🤖 I have created a release *beep* *boop* --- ## [2.17.1](https://togithub.com/googleapis/java-storage/compare/v2.17.0...v2.17.1) (2023-01-13) ### Bug Fixes * Update BaseStorageReadChannel to be left open unless explicitly closed ([#1853](https://togithub.com/googleapis/java-storage/issues/1853)) ([1425dd9](https://togithub.com/googleapis/java-storage/commit/1425dd97cb7d4a58f0bbededeca543f1a89c7d5d)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two new tests to verify new expected close behavior surfaced from java-storage-nio.
Fixes the scenario where a premature
java.nio.channels.ClosedChannelExceptioncould be thrown when using v2.17.0.