Skip to content

fix: fix DefaultBlobWriteSessionConfig init to work when grpc classes are excluded #3147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenWhitehead merged 1 commit into from
Jun 27, 2025
Merged

fix: fix DefaultBlobWriteSessionConfig init to work when grpc classes are excluded #3147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions ...e-cloud-storage/src/main/java/com/google/cloud/storage/DefaultBlobWriteSessionConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,6 @@ WriterFactory createFactory(Clock clock) {

@InternalApi
private static final class Factory implements WriterFactory {
private static final Decoder<WriteObjectResponse, BlobInfo>
WRITE_OBJECT_RESPONSE_BLOB_INFO_DECODER =
Conversions.grpc().blobInfo().compose(WriteObjectResponse::getResource);

private final int chunkSize;

Expand Down Expand Up @@ -172,7 +169,7 @@ public WritableByteChannelSession<?, BlobInfo> writeSession(
.setStartAsync(startResumableWrite)
.build();
})),
WRITE_OBJECT_RESPONSE_BLOB_INFO_DECODER);
Conversions.grpc().blobInfo().compose(WriteObjectResponse::getResource));
} else if (s instanceof StorageImpl) {
StorageImpl json = (StorageImpl) s;

Expand Down