Skip to content

fix: Pass app_profile_id when building updated request #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mariatta merged 3 commits into from
Feb 24, 2022
Merged

fix: Pass app_profile_id when building updated request #512

Mariatta merged 3 commits into from
Feb 24, 2022

Conversation

@Mariatta
Copy link
Contributor

@Mariatta Mariatta commented Feb 17, 2022

  • Pass the app_profile_id from the message
  • Update unittest

Fixes internal bug #214449800

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@Mariatta
fix: Pass app_profile_id when building updated request
908cd22 
- Pass the app_profile_id from the message
- Update unittest

Fixes internal bug #214449800
@Mariatta Mariatta requested review from a team as code owners February 17, 2022 20:13
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Feb 17, 2022
igorbernstein2
igorbernstein2 requested changes Feb 17, 2022
View reviewed changes
kolea2
kolea2 reviewed Feb 17, 2022
View reviewed changes
igorbernstein2
igorbernstein2 approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Mariatta Mariatta merged commit 2f8ba7a into main Feb 24, 2022
@Mariatta Mariatta deleted the request-retry-bug branch February 24, 2022 21:44
@release-please release-please bot mentioned this pull request Feb 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kolea2 kolea2 kolea2 approved these changes

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/python-bigtable API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mariatta @igorbernstein2 @kolea2