Skip to content

Change Type Hit at AsyncCollectionReference.document #369

@sizumita

Description

@sizumita

Is your feature request related to a problem? Please describe.

Return Type Hint at AsyncCollectionReference.document is always DocumentReference, but actually AsyncDocumentReference.
My Editor(Jetbrains IDE) tells me that AsyncDocumentReference is wrong Type.
スクリーンショット 2021-06-15 17 54 31

Describe the solution you'd like

I think to change Return Type Hint is the best solution:

def document(self, document_id: str = None) -> AsyncDocumentReference:
    """..."""
    return super().document(document_id)

Describe alternatives you've considered

I think this solution can change Return Type Hint simply.

Additional context

Nothing.

Metadata

Metadata

Assignees

Labels

api: firestoreIssues related to the googleapis/python-firestore API.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions