-
Notifications
You must be signed in to change notification settings - Fork 83
Closed
Labels
api: firestoreIssues related to the googleapis/python-firestore API.Issues related to the googleapis/python-firestore API.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
Description
Is your feature request related to a problem? Please describe.
Return Type Hint at AsyncCollectionReference.document is always DocumentReference, but actually AsyncDocumentReference.
My Editor(Jetbrains IDE) tells me that AsyncDocumentReference is wrong Type.

Describe the solution you'd like
I think to change Return Type Hint is the best solution:
def document(self, document_id: str = None) -> AsyncDocumentReference:
"""..."""
return super().document(document_id)Describe alternatives you've considered
I think this solution can change Return Type Hint simply.
Additional context
Nothing.
Metadata
Metadata
Assignees
Labels
api: firestoreIssues related to the googleapis/python-firestore API.Issues related to the googleapis/python-firestore API.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.