Skip to content

fix: stop / start stream after filter mismatch #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gcf-merge-on-green merged 3 commits into from
Jan 11, 2022
Merged

fix: stop / start stream after filter mismatch #502

gcf-merge-on-green merged 3 commits into from
Jan 11, 2022

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Dec 7, 2021 •
edited
Loading

Based on branch for PR #500 -- I will rebase after that PR merges.

Closes #367.

Supersedes PR #497.

@tseaver tseaver requested review from kolea2 and tswast December 7, 2021 21:28
@tseaver tseaver requested a review from a team as a code owner December 7, 2021 21:28
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Dec 7, 2021
@tseaver tseaver mentioned this pull request Dec 7, 2021
Closed
@tseaver tseaver force-pushed the 367-restart-watch-stream-after-filter-mismatch branch from 6f1ab8a to dba2dd5 Compare December 22, 2021 21:22
@tseaver tseaver force-pushed the 367-restart-watch-stream-after-filter-mismatch branch from dba2dd5 to a5da3fb Compare December 23, 2021 19:23
@tseaver
Copy link
Contributor Author

tseaver commented Dec 23, 2021

Flaky hash for DatetimeWithNanoseconds reported in googleapis/proto-plus-python#282

@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 23, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 23, 2021
@tseaver tseaver added the automerge Merge the pull request once unit tests and other checks pass. label Jan 11, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit a256752 into main Jan 11, 2022
@gcf-merge-on-green gcf-merge-on-green bot deleted the 367-restart-watch-stream-after-filter-mismatch branch January 11, 2022 19:04
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 11, 2022
@release-please release-please bot mentioned this pull request Jan 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes

@kolea2 kolea2 Awaiting requested review from kolea2

Assignees

@meredithslota meredithslota

Labels

api: firestore Issues related to the googleapis/python-firestore API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Collection on_snapshot incorrectly reports everything removed on internet reconnect

4 participants

@tseaver @tswast @meredithslota @yoshi-kokoro